From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8399716132B for ; Fri, 5 Apr 2024 11:26:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=145.40.73.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712316373; cv=none; b=pLtcuDIHl1JPZ36TANm1VvjCiXYvR/8WKJa+RSk9IdI6s3GVgH18a3U2Z4FirdhDzxeVJWfc8//bMdEe+XYYP4FtLtvuqysMLbfchzS050Ps6RcEBjt4Ge2iZyLiJoPZGvL/4+2bZArah26K7r5WS9V4k28bHHCxsYJh4bRVq1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712316373; c=relaxed/simple; bh=AMRPVsvI5Nb+bU3i5rw5NJTnOuE7WZWcpxBq0NNIJW8=; h=MIME-Version:Message-Id:In-Reply-To:References:Date:From:To:Cc: Subject:Content-Type; b=RhiMW/+6+0qfx6HeOmMZFi2StA+XGEOr709k7OGIBu/CgBqtEZkHume/lQRN7U0FB1r0sFWmnL5UtUv2XihkU/xnYm3ed0lD20bUhdcoZBDs6fj44gDuon5hdXtWRHW34dAWqwzLtFUfJNZYQzRA3pcCUxoAJpwY/47PpRd3kVs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZCHLFEzu; arc=none smtp.client-ip=145.40.73.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZCHLFEzu" Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 19A71CE36AE; Fri, 5 Apr 2024 11:26:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15543C433F1; Fri, 5 Apr 2024 11:26:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712316366; bh=AMRPVsvI5Nb+bU3i5rw5NJTnOuE7WZWcpxBq0NNIJW8=; h=In-Reply-To:References:Date:From:To:Cc:Subject:From; b=ZCHLFEzu7ooQeu3JhW5gMzG4vZ3pI/Zr22X4uVkkpnHQxTbi086KWJkbCAuWzmDZu ezFa8bbN3Z44L9Krtg1jPB9gxHSxv7C1bhZhf0TlW0I6pbfGpyLtmvItzOo1byjDky CHforGBTC++H1YqaqqWu0vTuAKrqgQmg3DczMUXla+gy4kwddNB5dbTQkqpy2BUW5H wCl8zGuyKbY/lOvYljmGxOYkW/S47hXx/Qn1/6lCiBmcTGpLsX5EtL/aFPnkbBpqWm ycfIsOvpomjcd80TsS7kGtlzw6sNhMFPiKgaSpbfbwqECH/ej+SYURUftAyn73so3k uxkec+udmKhpQ== Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfauth.nyi.internal (Postfix) with ESMTP id 1AD4F1200066; Fri, 5 Apr 2024 07:26:05 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Fri, 05 Apr 2024 07:26:05 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudegtddggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugeskhgvrhhnvghlrdhorhhgqeenucggtf frrghtthgvrhhnpedvtddtffejfeeggefgleefgfeghfehfeefffetgffgleegudevveet hfefjeevkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpegrrhhnugdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidquddvkeehudej tddvgedqvdekjedttddvieegqdgrrhhnugeppehkvghrnhgvlhdrohhrghesrghrnhgusg druggv X-ME-Proxy: Feedback-ID: i36794607:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 6DB2EB6008D; Fri, 5 Apr 2024 07:26:04 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-333-gbfea15422e-fm-20240327.001-gbfea1542 Precedence: bulk X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <11fdef9b-413d-4f88-b3d3-e5b27a88cf6f@app.fastmail.com> In-Reply-To: References: <20240403122851.38808-1-schnelle@linux.ibm.com> Date: Fri, 05 Apr 2024 13:24:28 +0200 From: "Arnd Bergmann" To: "Geert Uytterhoeven" Cc: "Michael Schmitz" , "Niklas Schnelle" , linux-m68k@lists.linux-m68k.org, "Heiko Carstens" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/1] m68k: Handle HAS_IOPORT dependencies Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri, Apr 5, 2024, at 12:16, Geert Uytterhoeven wrote: > On Wed, Apr 3, 2024 at 8:35=E2=80=AFPM Arnd Bergmann = wrote: >> On Wed, Apr 3, 2024, at 20:11, Michael Schmitz wrote: >> >> For the Q40, it may be better in the long run to change the >> drivers to just use MMIO directly though. > > Q40 uses ISA. Ah, indeed. I got confused by the NE2000 example as that contains "depends on (ISA || (Q40 && m)", which would have indicated that it's not actually using CONFIG_ISA. > Michael is worried about non-ISA drivers using inb() and friends. > At some point in time (i.e. eons ago), we were told it was better to > use in[bwl]()/read[bwl]() instead of directly dereferencing volatile > pointers... It's definitely still better to use an abstraction layer for MMIO accesses using inline asm instructions than open-coding the volatile pointer dereferences. Over time we have gotten better at defining which of the available abstractions should be used for a given bus, so inb()/outb() is now only really used for things derived from ISA in some form, including e.g. PCI and LPC. > Anyway, I don't think we have many users of inb() and friends left, and > I assume the bots should have detected any/most remaining users in Nik= las' > branch... > > arch/m68k/include/asm/floppy.h on Sun-3x might be the only offender? Could be. I think we can leave this one to whoever tries to get sun3x floppy support working, it's been marked broken for a while (see below). If there are any others, they will cause pretty obvious build failures once inb()/outb() are removed from the build, and they should be trivial to fix then. Arnd commit f1e0f28a85001f4faa3ea930fcf201933f42340e Author: akpm Date: Mon Jan 19 18:31:30 2004 +0000 [PATCH] M68k floppy selection =20 From: Geert Uytterhoeven =20 Floppy: On m68k, PC-style floppies are used on Q40/Q60 and Sun-3x on= ly. Sun-3x floppy is currently broken (needs I/O abstractions) =20 BKrev: 400c2282G1O-TsH5FiwzPbOorftQhg diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig index 2dce1d2699a9..32fdec34568e 100644 --- a/drivers/block/Kconfig +++ b/drivers/block/Kconfig @@ -6,7 +6,7 @@ menu "Block devices" =20 config BLK_DEV_FD tristate "Normal floppy disk support" - depends on !X86_PC9800 && !ARCH_S390 + depends on (!X86_PC9800 && !ARCH_S390 && !M68K) || Q40 || (SUN3X= && BROKEN) ---help--- If you want to use the floppy disk drive(s) of your PC under L= inux, say Y. Information about this driver, especially important for= IBM