public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Kars de Jong <jongk@linux-m68k.org>
Cc: Linux/m68k kernel mailing list <linux-m68k@vger.kernel.org>,
	linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: Conversion of old Amiga NCR53C9x drivers to esp_scsi
Date: Mon, 24 Nov 2008 17:00:42 -0600	[thread overview]
Message-ID: <1227567642.3568.5.camel@localhost.localdomain> (raw)
In-Reply-To: <1227560510.15190.18.camel@kars.perseus.home>

On Mon, 2008-11-24 at 22:01 +0100, Kars de Jong wrote:
> Hello everyone,
> 
> 
> After an initial failure in February this year I have now gotten my
> Blizzard SCSI Kit IV to work with the esp_scsi core.
> 
> It turns out the DMA engine doesn't like a transfer size of only 2 bytes
> (at least not when receiving). The bytes were in the FSC FIFO, but
> didn't get transferred to DRAM and the final interrupt didn't occur so
> the driver got stuck.

Oh, that's a known problem with some NCR chips.  The way the manual
recommends handling it as a PIO transaction to empty the DMA engine.
Checking whether this condition occurs can be tricky, though.

> The old driver used to do such small transfers using PIO, so that is
> what I do now in the glue driver.
> 
> What is the way to go? Revive the glue named drivers/scsi/blz1230.c?
> Or should it be renamed?

What I did when converting the 53c700 and 710 based drivers to the
generic core was simply to keep the old name and gut the innards of the
driver.  Whichever way you want to do it will be fine, though.

> Some of the other drivers may be a little more problematic because they
> had more driver operations which are not present in the esp_scsi DMA
> abstraction.

Any changes you need to make in the generic to support these, just post
here for review as a separate patch (and CC the esp_scsi maintainer:
Dave Miller).

James



      parent reply	other threads:[~2008-11-25  2:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-24 21:01 Conversion of old Amiga NCR53C9x drivers to esp_scsi Kars de Jong
2008-11-24 21:08 ` Michael Schmitz
2008-11-24 21:50 ` David Miller
2008-11-24 23:00 ` James Bottomley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1227567642.3568.5.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=jongk@linux-m68k.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox