Re: [PATCH] MVME16x: add support for EARLY_PRINTK

[Kars de Jong <jongk@linux-m68k.org>]

On di, 2008-11-25 at 02:26 +0100, Roman Zippel wrote:
> On Thursday 20. November 2008, Kars de Jong wrote:
> > diff --git a/arch/m68k/Kconfig.debug b/arch/m68k/Kconfig.debug
> > index f53b6d5..e0283a0 100644
> > --- a/arch/m68k/Kconfig.debug
> > +++ b/arch/m68k/Kconfig.debug
> > @@ -2,4 +2,15 @@ menu "Kernel hacking"
> >
> >  source "lib/Kconfig.debug"
> >
> > +config EARLY_PRINTK
> > +	bool "Early printk" if EMBEDDED
> > +	depends on MVME16x
> > +	default y
> > +	help
> 
> This is really misnamed, the option is mvme specific but the name is rather 
> generic. Depending on the code size you could include the code 
> unconditionally (like we do on other ports).

Defining CONFIG_EARLY_PRINTK used to pull in some generic code, that's
why I named it like that.

I grepped the source for CONFIG_EARLY_PRINTK, it seems the generic code
is gone.

So I think I'll just define it unconditionally, and only on MVME16x it
will actually include some extra code. Is that OK with you?


Kind regards, Kars.