Re: [PATCH 10/21] m68k/scsi: a2091 - Kill ugly DMA() macro

Geert Uytterhoeven
2010-04-05T19:42:40Z

On Mon, Apr 5, 2010 at 08:25, Christoph Hellwig <hch@infradead.org> wrote:
> Instead of abusing the ScsiHost base field I'd prefer if you stick

I wouldn't call it abuse: it's a (MM)IO base address anyway.
But I see that field was indeed marked `legacy crap' in an otherwise
innocent looking
commit to split the SCSI include files... by you ;-)

> a properly typed pointer into the device specific host data.

You mean shost_priv()? That field already contains a pointer to the
struct WD33C93_hostdata.

But I'll create a new a2091_hostdata struct that contains both the
WD33C93_hostdata and the a2091_scsiregs pointer (and do the same
for gvp11.c and a3000.c). It's a bit similar to what sgiwd93.c does, albeit that
one also uses the legacy base field.

Thx!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds