Re: [PATCH 10/21] m68k/scsi: a2091 - Kill ugly DMA() macro

Geert Uytterhoeven
2010-05-03T19:25:19Z

On Sun, May 2, 2010 at 22:05, James Bottomley <James.Bottomley@suse.de> wrote:
> On Fri, 2010-04-23 at 10:37 +0200, Geert Uytterhoeven wrote:
>> On Mon, Apr 5, 2010 at 21:42, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>> > On Mon, Apr 5, 2010 at 08:25, Christoph Hellwig <hch@infradead.org> wrote:
>> >> Instead of abusing the ScsiHost base field I'd prefer if you stick
>> >
>> > I wouldn't call it abuse: it's a (MM)IO base address anyway.
>> > But I see that field was indeed marked `legacy crap' in an otherwise
>> > innocent looking
>> > commit to split the SCSI include files... by you ;-)
>> >
>> >> a properly typed pointer into the device specific host data.
>> >
>> > You mean shost_priv()? That field already contains a pointer to the
>> > struct WD33C93_hostdata.
>> >
>> > But I'll create a new a2091_hostdata struct that contains both the
>> > WD33C93_hostdata and the a2091_scsiregs pointer (and do the same
>> > for gvp11.c and a3000.c). It's a bit similar to what sgiwd93.c does, albeit that
>> > one also uses the legacy base field.
>>
>> As I want to avoid introducing bugs by respinning the complicated
>> parts (the zorro
>> driver and platform driver conversion patches), I made this change on
>> top of the 2
>> whole patch series.
>>
>> A2091 part:
>
> I've applied up to 10/21 which should make it easier, but this patch

Thanks a lot! (I saw they showed up in linux-next, which is good!)

> refuses to apply:
>
> patch: **** malformed patch at line 230: struct scsi_cmnd *SCpnt,

Bummer. I sent those manually from gmail using copy-'n-paste from
gedit, which _used_
to work fine w.r.t. whitespace and line breaks. Oh well, they broke it :-(

> could you respin the remaining patches so they'll actually apply?

The remaining 11-21/21 from the original series had been sent using
git-send-email, so they should apply fine.

I'll resend the other 3 using git-send-email, too. The first 2 should
apply fine on top
of the series of 21.
The third won't apply as it depends on the Amiga platform rework, but we can
sort that out later. Or I can just take care of it myself, if you approve?

Thanks again!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds