From: Greg Ungerer <gerg@uclinux.org>
To: linux-m68k@vger.kernel.org
Cc: Greg Ungerer <gerg@uclinux.org>
Subject: [PATCH 4/5] m68knommu: remove un-needed exporting of COLDFIRE symbols
Date: Fri, 8 Apr 2011 22:17:01 +1000 [thread overview]
Message-ID: <1302265022-6614-5-git-send-email-gerg@uclinux.org> (raw)
In-Reply-To: <1302265022-6614-4-git-send-email-gerg@uclinux.org>
There is no reason most of the symbols enclosed in a conditional
on CONFIG_COLDFIRE need to be exported. And they sure don't need to
be doing it in m68k_ksyms_no.c. Move the dma symbols export (which
are currently needed) to the definitions of those, and remove the
rest of the exporting here.
Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
arch/m68k/kernel/m68k_ksyms_no.c | 12 ------------
arch/m68k/platform/coldfire/dma.c | 3 +++
2 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/arch/m68k/kernel/m68k_ksyms_no.c b/arch/m68k/kernel/m68k_ksyms_no.c
index 11effaa..db6f87a 100644
--- a/arch/m68k/kernel/m68k_ksyms_no.c
+++ b/arch/m68k/kernel/m68k_ksyms_no.c
@@ -42,15 +42,3 @@ EXPORT_SYMBOL(__mulsi3);
EXPORT_SYMBOL(__udivsi3);
EXPORT_SYMBOL(__umodsi3);
-#ifdef CONFIG_COLDFIRE
-extern unsigned int *dma_device_address;
-extern unsigned long dma_base_addr, _ramend;
-EXPORT_SYMBOL(dma_base_addr);
-EXPORT_SYMBOL(dma_device_address);
-EXPORT_SYMBOL(_ramend);
-
-extern asmlinkage void trap(void);
-extern void *_ramvec;
-EXPORT_SYMBOL(trap);
-EXPORT_SYMBOL(_ramvec);
-#endif /* CONFIG_COLDFIRE */
diff --git a/arch/m68k/platform/coldfire/dma.c b/arch/m68k/platform/coldfire/dma.c
index e88b95e..df5ce20 100644
--- a/arch/m68k/platform/coldfire/dma.c
+++ b/arch/m68k/platform/coldfire/dma.c
@@ -9,6 +9,7 @@
/***************************************************************************/
#include <linux/kernel.h>
+#include <linux/module.h>
#include <asm/dma.h>
#include <asm/coldfire.h>
#include <asm/mcfsim.h>
@@ -33,7 +34,9 @@ unsigned int dma_base_addr[MAX_M68K_DMA_CHANNELS] = {
MCFDMA_BASE3,
#endif
};
+EXPORT_SYMBOL(dma_base_addr);
unsigned int dma_device_address[MAX_M68K_DMA_CHANNELS];
+EXPORT_SYMBOL(dma_device_address);
/***************************************************************************/
--
1.7.0.4
next prev parent reply other threads:[~2011-04-08 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 12:16 [PATCH 0/5] m68k: merge mmu and non-mmu kernel/m68k_ksyms.c files Greg Ungerer
2011-04-08 12:16 ` [PATCH 1/5] m68knommu: move EXPORT of dump_fpu to function definition Greg Ungerer
2011-04-08 12:16 ` [PATCH 2/5] m68knommu: move EXPORT of local checksumming functions to definitions Greg Ungerer
2011-04-08 12:17 ` [PATCH 3/5] m68knommu: move EXPORT of kernel_thread to function definition Greg Ungerer
2011-04-08 12:17 ` Greg Ungerer [this message]
2011-04-08 12:17 ` [PATCH 5/5] m68k: merge non-mmu and mmu versions of m68k_ksyms.c Greg Ungerer
-- strict thread matches above, loose matches on Subject: below --
2011-04-21 0:48 [PATCH 0/5] m68k: merge and clean up of arch/m68k/kernel/m68k_ksyms*.c files gerg
2011-04-21 0:48 ` [PATCH 1/5] m68knommu: move EXPORT of dump_fpu to function definition gerg
2011-04-21 0:48 ` [PATCH 2/5] m68knommu: move EXPORT of local checksumming functions to definitions gerg
2011-04-21 0:48 ` [PATCH 3/5] m68knommu: move EXPORT of kernel_thread to function definition gerg
2011-04-21 0:48 ` [PATCH 4/5] m68knommu: remove un-needed exporting of COLDFIRE symbols gerg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302265022-6614-5-git-send-email-gerg@uclinux.org \
--to=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox