Re: [uClinux-dev] [PATCH v2 1/6] m68k: merge mmu and non-mmu versions of muldi3

Greg Ungerer
2011-04-20T09:09:07Z

Hi Sam,

On 20/04/11 18:06, Sam Ravnborg wrote:
> Hi Greg.
>
>> +
>> +#if defined(__mc68020__) || defined(__mc68030__) || \
>> + defined(__mc68040__) || defined(__mc68060__)
>
> Why use these to decide if this is MMU or not?

The asm code that is enclosed by this is not about having an MMU
or not. It is about the processor supporting the 64bit mul
instruction.

> This code is not exposed to user-space so we can rely on CONFIG_* symbols.
> IMO the CONIFG_* symbols is easier to read/maintain.

In general yes I agree. But in this specific case it really
is about a code generation option (what type of processor
instructions we can emit).

Regards
Greg

------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com