From: Geert Uytterhoeven <geert@linux-m68k.org>
To: linux-m68k@lists.linux-m68k.org
Cc: linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH 4/5] m68k/amiga: Chip RAM - Change chipavail to an atomic_t
Date: Sat, 21 May 2011 21:18:19 +0200 [thread overview]
Message-ID: <1306005500-29259-4-git-send-email-geert@linux-m68k.org> (raw)
In-Reply-To: <1306005500-29259-1-git-send-email-geert@linux-m68k.org>
While the core resource handling code is safe, our global counter must
still be protected against concurrent modifications.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
arch/m68k/amiga/chipram.c | 15 +++++++++------
1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/arch/m68k/amiga/chipram.c b/arch/m68k/amiga/chipram.c
index e5a8dbc..c3fe451 100644
--- a/arch/m68k/amiga/chipram.c
+++ b/arch/m68k/amiga/chipram.c
@@ -16,6 +16,7 @@
#include <linux/string.h>
#include <linux/module.h>
+#include <asm/atomic.h>
#include <asm/page.h>
#include <asm/amigahw.h>
@@ -25,7 +26,7 @@ EXPORT_SYMBOL(amiga_chip_size);
static struct resource chipram_res = {
.name = "Chip RAM", .start = CHIP_PHYSADDR
};
-static unsigned long chipavail;
+static atomic_t chipavail;
void __init amiga_chip_init(void)
@@ -36,7 +37,7 @@ void __init amiga_chip_init(void)
chipram_res.end = amiga_chip_size-1;
request_resource(&iomem_resource, &chipram_res);
- chipavail = amiga_chip_size;
+ atomic_set(&chipavail, amiga_chip_size);
}
@@ -84,7 +85,7 @@ void *amiga_chip_alloc_res(unsigned long size, struct resource *res)
return NULL;
}
- chipavail -= size;
+ atomic_sub(size, &chipavail);
pr_debug("amiga_chip_alloc_res: returning %pR\n", res);
return (void *)ZTWO_VADDR(res->start);
}
@@ -101,7 +102,7 @@ void amiga_chip_free(void *ptr)
*p = res->sibling;
size = res->end-start;
pr_debug("amiga_chip_free: free %lu bytes at %p\n", size, ptr);
- chipavail += size;
+ atomic_add(size, &chipavail);
kfree(res);
return;
}
@@ -113,8 +114,10 @@ EXPORT_SYMBOL(amiga_chip_free);
unsigned long amiga_chip_avail(void)
{
- pr_debug("amiga_chip_avail : %lu bytes\n", chipavail);
- return chipavail;
+ unsigned long n = atomic_read(&chipavail);
+
+ pr_debug("amiga_chip_avail : %lu bytes\n", n);
+ return n;
}
EXPORT_SYMBOL(amiga_chip_avail);
--
1.7.0.4
next prev parent reply other threads:[~2011-05-21 19:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-21 19:18 [PATCH 1/5] m68k/amiga: Chip RAM - Use tabs for indentation Geert Uytterhoeven
2011-05-21 19:18 ` [PATCH 2/5] m68k/amiga: Chip RAM - Convert from printk() to pr_*() Geert Uytterhoeven
2011-05-21 19:18 ` [PATCH 3/5] m68k/amiga: Chip RAM - Always allocate from the start of memory Geert Uytterhoeven
2011-05-21 19:18 ` Geert Uytterhoeven [this message]
2011-05-21 19:18 ` [PATCH 5/5] m68k/amiga: Chip RAM - Use resource_size() to fix off-by-one error Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306005500-29259-4-git-send-email-geert@linux-m68k.org \
--to=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox