public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "James E.J. Bottomley" <JBottomley@parallels.com>
Cc: linux-scsi@vger.kernel.org, linux-m68k@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Michael Schmitz <schmitz@debian.org>
Subject: [PATCH 1/8] scsi/atari: Provide a dummy NCR5380_exit()
Date: Mon, 13 Jun 2011 20:39:15 +0200	[thread overview]
Message-ID: <1307990362-22768-2-git-send-email-geert@linux-m68k.org> (raw)
In-Reply-To: <1307990362-22768-1-git-send-email-geert@linux-m68k.org>

and call it from atari_scsi_release(), cfr. the other NCR5380 drivers.

This fixes:

drivers/scsi/NCR5380.h:303: warning: ‘NCR5380_exit’ declared ‘static’ but never defined

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Michael Schmitz <schmitz@debian.org>
---
 drivers/scsi/atari_NCR5380.c |    5 +++++
 drivers/scsi/atari_scsi.c    |    1 +
 2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/atari_NCR5380.c b/drivers/scsi/atari_NCR5380.c
index 24652f1..2db79b4 100644
--- a/drivers/scsi/atari_NCR5380.c
+++ b/drivers/scsi/atari_NCR5380.c
@@ -892,6 +892,11 @@ static int __init NCR5380_init(struct Scsi_Host *instance, int flags)
 	return 0;
 }
 
+static void NCR5380_exit(struct Scsi_Host *instance)
+{
+	/* Empty, as we didn't schedule any delayed work */
+}
+
 /*
  * Function : int NCR5380_queue_command (Scsi_Cmnd *cmd,
  *	void (*done)(Scsi_Cmnd *))
diff --git a/drivers/scsi/atari_scsi.c b/drivers/scsi/atari_scsi.c
index 3e8658e..04a154f 100644
--- a/drivers/scsi/atari_scsi.c
+++ b/drivers/scsi/atari_scsi.c
@@ -730,6 +730,7 @@ int atari_scsi_release(struct Scsi_Host *sh)
 		free_irq(IRQ_TT_MFP_SCSI, sh);
 	if (atari_dma_buffer)
 		atari_stram_free(atari_dma_buffer);
+	NCR5380_exit(sh);
 	return 1;
 }
 
-- 
1.7.0.4

  reply	other threads:[~2011-06-13 18:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-13 18:39 M68k SCSI compile warning fixes Geert Uytterhoeven
2011-06-13 18:39 ` Geert Uytterhoeven [this message]
2011-06-13 18:39 ` [PATCH 2/8] scsi/mac: macscsi_detect() should be __init Geert Uytterhoeven
2011-06-13 18:39 ` [PATCH 3/8] scsi/mac: Remove unused variable default_instance Geert Uytterhoeven
2011-06-13 18:39 ` [PATCH 4/8] scsi/sun3: sun3scsi_detect() and NCR5380_init() should be __init Geert Uytterhoeven
2011-06-13 18:39 ` [PATCH 5/8] scsi/sun3: Provide a dummy NCR5380_exit() Geert Uytterhoeven
2011-06-13 18:39 ` [PATCH 6/8] scsi/sun3: Check for NCR_TIMEOUT being defined instead of having a value Geert Uytterhoeven
2011-06-13 18:39 ` [PATCH 7/8] scsi/sun3: Add various missing NDEBUG* definitions Geert Uytterhoeven
2011-06-13 18:39 ` [PATCH 8/8] scsi/sun3: Remove commented out merge_contiguous_buffers Geert Uytterhoeven
2011-06-13 18:41 ` [PATCH 0/8] M68k SCSI compile warning fixes Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307990362-22768-2-git-send-email-geert@linux-m68k.org \
    --to=geert@linux-m68k.org \
    --cc=JBottomley@parallels.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=schmitz@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox