From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Matt Porter <mporter@kernel.crashing.org>,
Herbert Valerio Riedel <hvr@gnu.org>,
MontaVista Software <source@mvista.com>,
Kyle McMartin <kyle@mcmartin.ca>, Helge Deller <deller@gmx.de>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
"linux-parisc@vger.kernel.org" <linux-parisc@vger.kernel.org>,
Sam Creasey <sammy@sammy.net>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"linux-m68k@vger.kernel.org" <linux-m68k@vger.kernel.org>
Subject: Re: [RFC 54/72] au1000_eth/mipsnet/tc35815: Move the MIPS drivers
Date: Sat, 25 Jun 2011 11:11:21 -0700 [thread overview]
Message-ID: <1309025482.2454.90.camel@jtkirshe-mobl> (raw)
In-Reply-To: <20110625161353.GA20976@linux-mips.org>
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
On Sat, 2011-06-25 at 09:13 -0700, Ralf Baechle wrote:
> On Sat, Jun 25, 2011 at 06:59:05AM -0700, Jeff Kirsher wrote:
>
> > Move the MIPS drivers into drivers/net/ethernet/mips/ and
> > make the necessary Kconfig and Makefile changes.
>
> NAck.
>
> sni_82596.c is a driver for the same chip but used in particular
> Siemens-
> Nixdorf systems. Lasi_82596 is an Intel NIC being used in PARISC
> systems.
> Not a good reason th throw PA-RISC drivers into the same directory
> after
> all PA-RISC has no relation to MIPS at all. So maybe they should go
> into
> drivers/net/ethernet/i82596 or drivers/net/ethernet/intel. And
> wherever
> they go, both drivers #include lib82596.c which your patch did not
> move
> around.
My bad, I had grouped these drivers because they both used lib82596.c
and had thought I had moved that file as well.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
prev parent reply other threads:[~2011-06-25 18:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1309010363-22750-1-git-send-email-jeffrey.t.kirsher@intel.com>
[not found] ` <1309010363-22750-55-git-send-email-jeffrey.t.kirsher@intel.com>
2011-06-25 16:13 ` [RFC 54/72] au1000_eth/mipsnet/tc35815: Move the MIPS drivers Ralf Baechle
2011-06-25 18:11 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309025482.2454.90.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=geert@linux-m68k.org \
--cc=hvr@gnu.org \
--cc=jejb@parisc-linux.org \
--cc=kyle@mcmartin.ca \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mporter@kernel.crashing.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=sammy@sammy.net \
--cc=source@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox