Re: [PATCH 00/28 v6] m68k: Convert to genirq

Finn Thain
2011-09-13T11:11:44Z

Hi Geert,

When I was testing your v5 patch series, I had to patch macmace.c to
resolve some compiler errors --

--- linux-m68k.orig/drivers/net/macmace.c 2011-09-13 18:33:55.000000000 +1000
+++ linux-m68k/drivers/net/macmace.c 2011-09-13 18:34:05.000000000 +1000
@@ -31,8 +31,8 @@
#include <linux/dma-mapping.h>
#include <linux/platform_device.h>
#include <linux/gfp.h>
+#include <linux/interrupt.h>
#include <asm/io.h>
-#include <asm/irq.h>
#include <asm/macints.h>
#include <asm/mac_psc.h>
#include <asm/page.h>

Would you please check whether this is still needed after the v6 series?
(I'd check myself, but I don't have the source tree on which your emailed
patches were based...)

BTW, you'll probably want to patch this comment in
include/linux/interrupt.h --

/*
* Special function to avoid ifdeffery in kernel/irq/devres.c which
* gets magically built by GENERIC_HARDIRQS=n architectures (sparc,
* m68k).

Finn