Re: [PATCH 07/28] m68k/irq: Switch irq_chip methods to "struct irq_data *data"

Finn Thain
2011-09-12T02:48:30Z

[-- Attachment #1: Type: TEXT/PLAIN, Size: 733 bytes --]

On Sun, 11 Sep 2011, Geert Uytterhoeven wrote:

>
> > @@ -152,7 +149,7 @@ void baboon_irq_enable(int irq)
> >
> >        baboon_disabled &= ~(1 << irq_idx);
> >        if (!baboon_disabled)
> > -               mac_enable_irq(IRQ_NUBUS_C);
> > +               mac_irq_enable(irq_get_irq_data(IRQ_NUBUS_C));
>
> irq_get_irq_data() is not available in the non-genirq case, so this
> cleanup cannot be folded in patch 7, and has to wait until after patch
> 27.

Right, I forgot about that.

>
> I'll add it at the end of the series, OK?

That's fine. Please go ahead and add my signed-off-by tag (or I can
resubmit if you would prefer).

Finn

>
> Gr{oetje,eeting}s,
>
>                         Geert