Re: [PATCH 24/36] m68k: compile appropriate mm arch files for ColdFire V4e MMU support

Geert Uytterhoeven
2011-10-30T13:46:18Z

On Tue, Oct 25, 2011 at 09:19, <gerg@snapgear.com> wrote:
> From: Greg Ungerer <gerg@uclinux.org>
>
> Compile the mcfmmu.c code when the ColdFire V4e MMU is enabled.
> And don't compile the unnecessary hwtest.c code for it.
>
> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
> ---
>  arch/m68k/mm/Makefile |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/arch/m68k/mm/Makefile b/arch/m68k/mm/Makefile
> index 09cadf1..1732e31 100644
> --- a/arch/m68k/mm/Makefile
> +++ b/arch/m68k/mm/Makefile
> @@ -4,6 +4,12 @@
>
>  obj-y  := init.o
>
> -obj-$(CONFIG_MMU)              += cache.o fault.o hwtest.o
> +obj-$(CONFIG_MMU)              += cache.o fault.o
>  obj-$(CONFIG_MMU_MOTOROLA)     += kmap.o memory.o motorola.o
>  obj-$(CONFIG_MMU_SUN3)         += sun3kmap.o sun3mmu.o
> +
> +ifdef CONFIG_COLDFIRE
> +obj-$(CONFIG_MMU)              += kmap.o memory.o mcfmmu.o

What about introducing CONFIG_MMU_COLDFIRE and writing

obj-$(CONFIG_MMU_MOTOROLA) += kmap.o memory.o mcfmmu.o

instead?

It could turn out to be useful in other places too, especially when considering
merging more mm/no sources files.

> +else
> +obj-$(CONFIG_MMU)              += hwtest.o
> +endif

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds