Re: [PATCH] m68k/irq: don't use pr_crit in an header

Thorsten Glaser
2011-12-17T21:24:19Z

Uwe Kleine-König dixit:

>so better use plain printk with KERN_CRIT directly.

Wasn’t it considered good style to switch f̲r̲o̲m̲ that t̲o̲ pr_crit?

In that case, my other patch from Message-ID
<Pine.BSM.4.64L.1112171426140.856@herc.mirbsd.org> can still
be used. Feel free to assume a Signed-off on that by me, if
this is the desired direction of change.

(Of course, aufs changes notwithstanding.)

bye,
//mirabilos
--
Support mksh as /bin/sh and RoQA dash NOW!
‣ src:bash (240 (258) bugs: 0 RC, 167 (181) I&N, 73 (77) M&W, 0 F&P)
‣ src:dash (72 (82) bugs: 3 RC, 27 (30) I&N, 42 (49) M&W, 0 F&P)
‣ src:mksh (1 bug: 0 RC, 0 I&N, 1 M&W, 0 F&P)
http://qa.debian.org/data/bts/graphs/d/dash.png is pretty red, innit?