Re: aufs vs. m68k conflict, please advice

Thorsten Glaser
2011-12-17T19:12:13Z

Uwe Kleine-K�nig dixit:

>On Sat, Dec 17, 2011 at 02:28:35PM +0000, Thorsten Glaser wrote:

>> Maybe something like this?
[…]
>> Just an idea of the moment,

Well, it does make the thing compile with minimal effort.

>IMHO the problem is that aufs provides an incomplete definition of
>pr_fmt. Either it should define AUFS_NAME on the commandline, too, or
>should define pr_fmt in an aufs header (or a .c file) #included after
>all other headers and only when AUFS_NAME is defined, too.

My initial thoughts, too.

>The ugly thing about aufs' pr_fmt being already there when ack_bad_irq
>is defined is, that the message printed by the pr_crit suddenly looks
>aufs specific which it clearly isn't. So it should better make sure that
>the definition isn't available to ack_bad_irq.

True, but looking at the actual changes, it doesn’t look too aufs
specific to me. (If the function ack_bad_irq is instantiated in
the aufs code at all, which is debatable; a quick fgrep -r doesn’t
find anything.)

Anyway, will please someone communicate that to the aufs developers
and include some sort of fix in the next upload? (My build is still
compiling, 132 bogomips is fast; will communicate success or failure
of the kernel in general.)

Thanks,
//mirabilos
--
<dileks> ch: good, you corrected yourself. ppl tend to tweet such news
immediately, sth. like "grml devs seem to be buyable" <ch> dileks: we
_are_. if you throw enough money in our direction, things will happen
<mika> everyone is buyable, it's just a matter of price <mrud> and now
comes [mira] and uses this as a signature ;0 -- they asked for it…