Re: [PATCH 3/3] m68k: merge mmu and non-mmu versions of time.c

Greg Ungerer
2012-02-21T06:42:16Z

Hi Geert,

On 19/02/12 20:10, Geert Uytterhoeven wrote:
> On Tue, Feb 7, 2012 at 04:09,<gerg@snapgear.com> wrote:
>> +int update_persistent_clock(struct timespec now)
>> +{
>> + return set_rtc_mmss(now.tv_sec);
>> +}
>
> This adds update_persistent_clock() for MMU, which was not present before.
> It's only called if CONFIG_GENERIC_CMOS_UPDATE is set, but
> arch/m68k/Kconfig has:
>
> config GENERIC_CMOS_UPDATE
> def_bool !MMU

Yep. Again I was trying to just have fewer #ifdefs.

But looking at this further, I don't think there is any point having
CONFIG_GENERIC_CMOS_UPDATE defined for the non-MMU case. The code for
update_persistent_clock() calls set_rtc_mmss() which relies on the
sub-arch code having set mach_set_clock_mmss to do the real work. But
that is not set for any non-MMU code paths. Seems like we can remove it
for everyone m68k type. Or did I miss something :-)

Regards
Greg

------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com