Re: [PATCH 00/11] m68knommu: remove ColdFire sub-architecture directories

Greg Ungerer
2012-05-02T14:08:42Z

Hi Luis,

On 05/02/2012 07:50 PM, Luis Alves wrote:
> I've done a similar thing for the 68000 cpu's. Ended up with a single
> platform/68000 directory and removed the 68328, 68EZ328 and 68VZ328
> directories.

That sounds great.

> When I have the time I'll prepare the patches and send them (probably
> latter today).

Looking forward to them :-)

> I'm not sure if anyone is still building 3.x kernels for the 68[xx]328
> SoC's but would be nice if someone could test building the kernel for
> the boards using those chips (hopefully I didn't break up anything).
> For the 68000 (and my board) it's working good.

I build them occasionally, but I don't have any way to test any
of those targets.

Regards
Greg

> On Wed, May 2, 2012 at 2:08 AM,<gerg@snapgear.com> wrote:
>>
>> Currently the different ColdFire sub-archiectures are split up with a
>> directory for each family type. Most though only contain a small amount
>> of code, it just doesn't seem to make any sense to keep them separate.
>>
>> Move all the ColdFire sub-architecture code into the platform/coldfire
>> directory, and remove the sub-architecture directories. We already build
>> the common ColdFire components based on sub-architecture type anyway,
>> so there is very little Makefile change required.
>>
>> Overall we remove about 200 lines of duplicated Makefile code, and end
>> up with all the ColdFire specific code in a single directory.
>>
>> ---
>>
>> Ã¡arch/m68k/Makefile Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ | Ã¡ 10 ----------
>> Ã¡arch/m68k/platform/5206/Makefile Ã¡ Ã¡ Ã¡ | Ã¡ 18 ------------------
>> Ã¡arch/m68k/platform/520x/Makefile Ã¡ Ã¡ Ã¡ | Ã¡ 17 -----------------
>> Ã¡arch/m68k/platform/523x/Makefile Ã¡ Ã¡ Ã¡ | Ã¡ 17 -----------------
>> Ã¡arch/m68k/platform/5249/Makefile Ã¡ Ã¡ Ã¡ | Ã¡ 18 ------------------
>> Ã¡arch/m68k/platform/5272/Makefile Ã¡ Ã¡ Ã¡ | Ã¡ 18 ------------------
>> Ã¡arch/m68k/platform/527x/Makefile Ã¡ Ã¡ Ã¡ | Ã¡ 18 ------------------
>> Ã¡arch/m68k/platform/528x/Makefile Ã¡ Ã¡ Ã¡ | Ã¡ 18 ------------------
>> Ã¡arch/m68k/platform/5307/Makefile Ã¡ Ã¡ Ã¡ | Ã¡ 20 --------------------
>> Ã¡arch/m68k/platform/532x/Makefile Ã¡ Ã¡ Ã¡ | Ã¡ 18 ------------------
>> Ã¡arch/m68k/platform/5407/Makefile Ã¡ Ã¡ Ã¡ | Ã¡ 18 ------------------
>> Ã¡arch/m68k/platform/54xx/Makefile Ã¡ Ã¡ Ã¡ | Ã¡ 19 -------------------
>> Ã¡arch/m68k/platform/coldfire/Makefile Ã¡ | Ã¡ 24 ++++++++++++++----------
>> Ã¡b/arch/m68k/Makefile Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ Ã¡ | Ã¡ Ã¡2 --
>> Ã¡b/arch/m68k/platform/coldfire/Makefile | Ã¡ Ã¡4 ++--
>> Ã¡b/arch/m68k/platform/coldfire/m5206.c Ã¡| Ã¡ Ã¡1 -
>> Ã¡b/arch/m68k/platform/coldfire/m520x.c Ã¡| Ã¡ Ã¡1 -
>> Ã¡b/arch/m68k/platform/coldfire/m523x.c Ã¡| Ã¡ Ã¡1 -
>> Ã¡b/arch/m68k/platform/coldfire/m5249.c Ã¡| Ã¡ Ã¡1 -
>> Ã¡b/arch/m68k/platform/coldfire/m5272.c Ã¡| Ã¡ Ã¡1 -
>> Ã¡b/arch/m68k/platform/coldfire/m527x.c Ã¡| Ã¡ Ã¡1 -
>> Ã¡b/arch/m68k/platform/coldfire/m528x.c Ã¡| Ã¡ Ã¡1 -
>> Ã¡b/arch/m68k/platform/coldfire/m532x.c Ã¡| Ã¡ Ã¡1 -
>> Ã¡b/arch/m68k/platform/coldfire/m5407.c Ã¡| Ã¡ Ã¡1 -
>> Ã¡b/arch/m68k/platform/coldfire/m54xx.c Ã¡| Ã¡ Ã¡1 -
>> Ã¡b/arch/m68k/platform/coldfire/nettel.c | Ã¡ Ã¡1 -
>> Ã¡26 files changed, 16 insertions(+), 234 deletions(-)
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at Ã¡http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>

--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close, FAX: +61 7 3891 3630
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com