Re: [PATCH 0/13] Atari EtherNAT/EtherNEC/NetUSBee support

Geert Uytterhoeven
2013-04-09T20:55:44Z

Hi Michael,

On Sat, Apr 6, 2013 at 2:26 AM, Michael Schmitz <schmitzmic@gmail.com> wrote:
> here's my rewrite of the Atari patch series for upstream submission -
> the only changes are to patches 9 and 12.
>
> The USB patch no longer disables the chip interrupt in the interrupt
> handler - it turns out this wasn't necessary at all. It also does away
> with direct writes to the EtherNAT interrupt control register, and uses
> enable_irq() and disable_irq() instead. The probe code has become a lot
> cleaner as a result.

Thanks, I applied all of them, with some minor changes:
- Changed one instance of ATARI to ATARI_ETHERNAT in
drivers/net/ethernet/smsc/Kconfig, for consistency,
- Split too long comments,
- Made platform device structures and isp1160_delay() in
arch/m68k/atari/config.c depend on the appropriate CONFIG_* symbols, else
you get unused warnings from the compiler if CONFIG_ETHERNAT and/or
CONFIG_ETHERNEC are not set.

I also updated your old series for the m68k master branch to the
latest corresponding
version for upstream, so master == m68k-queue.

Please send the patches for drivers/net and drivers/usb to the net resp. usb
mailing lists, to collects acks and comments.

Thanks again!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds