Re: [PATCH 11/12] m68k/atari: USB - add platform devices for EtherNAT/NetUSBee ISP1160 HCD

Michael Schmitz
2013-09-07T11:48:29Z

Hi Geert,

>> I believe the ISP116x driver checks for IORESOURCE_MEM resources
>> explicitly, that is why they are defined that way. I may have that
>> wrong or confuse this with the EtherNAT ethernet driver though.
>>
>> The 0x3xx address is for the NetUSBee case - the EtherNAT USB will be
>> in the 0x80000xx ballpark, does that matter with IO resources?
>
> As the ISA I/O ports are memory mapped on m68k anyway, it doesn't
> matter that much, and will just work. But semantically the I/O region is
> part of I/O space, not memory space.

Fine, no objections to changing it then. I'll test that once I return,
but I trust your judgemebt there - it's cleaner, so let's fix it.

Cheers,

Michael

On Wed, Sep 4, 2013 at 3:23 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Wed, Sep 4, 2013 at 2:26 PM, Michael Schmitz <schmitzmic@gmail.com> wrote:
>> On Mon, Aug 26, 2013 at 12:18 PM, Geert Uytterhoeven
>> <geert@linux-m68k.org> wrote:
>>> On Sat, Apr 6, 2013 at 2:26 AM, Michael Schmitz <schmitzmic@gmail.com> wrote:
>>>> --- a/arch/m68k/atari/config.c
>>>> +++ b/arch/m68k/atari/config.c
>>>
>>>> +static struct resource isp1160_resources[] = {
>>>> + [0] = {
>>>> + .name = "isp1160-data",
>>>> + .start = ATARI_USB_PHYS_ADDR,
>>>> + .end = ATARI_USB_PHYS_ADDR + 0x1,
>>>> + .flags = IORESOURCE_MEM,
>>>
>>> Shouldn't this be IORESOURCE_IO?
>>>
>>>> + },
>>>> + [1] = {
>>>> + .name = "isp1160-regs",
>>>> + .start = ATARI_USB_PHYS_ADDR + 0x4,
>>>> + .end = ATARI_USB_PHYS_ADDR + 0x5,
>>>> + .flags = IORESOURCE_MEM,
>>>
>>> Ditto.
>>>
>>>> + },
>>>
>>> I have in /proc/iomem:
>>>
>>> 00000340-00000341 : isp1160-data
>>> 00000360-00000361 : isp1160-regs
>>> 00684000-00783fff : ST-RAM Pool
>>> 00684000-006cffff : atafb
>>> 006d0000-006d3fff : ataflop
>>> 006d4000-006d4fff : SCSI
>>> fff00000-fff0003f : falconide
>>>
>>> and in /proc/ioports:
>>>
>>> 00000300-0000031f : rtl8019-regs
>>
>> I believe the ISP116x driver checks for IORESOURCE_MEM resources
>> explicitly, that is why they are defined that way. I may have that
>> wrong or confuse this with the EtherNAT ethernet driver though.
>>
>> The 0x3xx address is for the NetUSBee case - the EtherNAT USB will be
>> in the 0x80000xx ballpark, does that matter with IO resources?
>
> As the ISA I/O ports are memory mapped on m68k anyway, it doesn't
> matter that much, and will just work. But semantically the I/O region is
> part of I/O space, not memory space.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds