public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Petr Stehlik <pstehlik@sophics.cz>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Thorsten Glaser <tg@mirbsd.de>,
	linux-m68k@vger.kernel.org, aranym@lists.bobek.cz
Subject: Re: [PATCH] make NatFeat drivers bool, not tristate
Date: Wed, 24 Jul 2013 17:02:20 +0200	[thread overview]
Message-ID: <1374678140.18072.10.camel@pracovni> (raw)
In-Reply-To: <alpine.DEB.2.02.1307241645500.8930@ayla.of.borg>

Geert Uytterhoeven píše v St 24. 07. 2013 v 16:56 +0200:
> > > >The problem is that aranym expects the parameters of the natfeat calls
> > > >to be physical addresses.  The nf_get_id calls use literal strings as
> > > >parameters which only works when the drivers are builtin because phys ==
> > > >virt then.
> 
> And fixing the conversion is non-trivial, as module memory is allocated using
> vmalloc(), which may be non-contiguous in physical memory space, right?

Sounds like the original design decision of NatFeats to use ASCII names
instead of cryptic integer codes wasn't that smart.

> ARAnyM hackers: What's the maximum size of ID names?

There isn't any given limit AFAIK, it's based on a common sense when
creating a new NatFeat name.

Petr

  reply	other threads:[~2013-07-24 15:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23 22:51 [PATCH] make NatFeat drivers bool, not tristate Thorsten Glaser
2013-07-24  8:57 ` Andreas Schwab
2013-07-24 12:42   ` Thorsten Glaser
2013-07-24 13:26     ` Thorsten Glaser
2013-07-24 14:56       ` Geert Uytterhoeven
2013-07-24 15:02         ` Petr Stehlik [this message]
2013-07-24 16:19           ` Geert Uytterhoeven
2013-07-24 20:04             ` Petr Stehlik
2013-07-24 17:23         ` Thorsten Glaser
2013-07-24 17:40           ` Geert Uytterhoeven
2013-07-29 21:52 ` Geert Uytterhoeven
2013-07-30  8:50   ` Thorsten Glaser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374678140.18072.10.camel@pracovni \
    --to=pstehlik@sophics.cz \
    --cc=aranym@lists.bobek.cz \
    --cc=geert@linux-m68k.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=tg@mirbsd.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox