From: Michael Schmitz <schmitzmic@gmail.com>
To: geert@linux-m68k.org
Cc: linux-m68k@vger.kernel.org, Michael Schmitz <schmitz@debian.org>
Subject: [PATCH] m68k/irq - use polled IRQ flag for MFP timer cascaded interrupts
Date: Sat, 11 Jan 2014 14:01:31 +1300 [thread overview]
Message-ID: <1389402091-20815-1-git-send-email-schmitz@debian.org> (raw)
Some Atari hardware has no capacity to raise interrupts (e.g.
network or USB adapter hardware attached via ROM port). The driver
interrupt routine is called from a timer interrupt (timer D) in
these cases, using chained device specific pseudo interrupts
(IRQ_MFP_TIMER1 ff.)
These interrupts will more often than not, return IRQ_NONE as
there is not always work for the device handler when called.
Too many unhandled interrupts will result in the interrupt
being disabled by the stuck interrupt watchdog.
As preferred option to flag interrupts as needing exclusion
from the watchdog mechanism, tglx added the IRQ_IS_POLLED flag
for use in such a case. Currently, two interrupts need to use
this flag. Add more users as needed.
This patch obsoletes the introduction of handle_polled_irq()
in the m68k tree.
Signed-off-By: Michael Schmitz <schmitz@debian.org>
---
arch/m68k/atari/ataints.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/arch/m68k/atari/ataints.c b/arch/m68k/atari/ataints.c
index 90f7a48..3e73a63 100644
--- a/arch/m68k/atari/ataints.c
+++ b/arch/m68k/atari/ataints.c
@@ -330,9 +330,12 @@ void __init atari_init_IRQ(void)
sound_ym.rd_data_reg_sel = 7;
sound_ym.wd_data = 0xff;
- m68k_setup_irq_controller(&atari_mfptimer_chip, handle_polled_irq,
+ m68k_setup_irq_controller(&atari_mfptimer_chip, handle_simple_irq,
IRQ_MFP_TIMER1, 8);
+ irq_set_status_flags(IRQ_MFP_TIMER1, IRQ_IS_POLLED);
+ irq_set_status_flags(IRQ_MFP_TIMER2, IRQ_IS_POLLED);
+
/* prepare timer D data for use as poll interrupt */
/* set Timer D data Register - needs to be > 0 */
st_mfp.tim_dt_d = 254; /* < 100 Hz */
--
1.7.0.4
next reply other threads:[~2014-01-11 1:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-11 1:01 Michael Schmitz [this message]
2014-01-11 10:39 ` [PATCH] m68k/irq - use polled IRQ flag for MFP timer cascaded interrupts Geert Uytterhoeven
[not found] <1387611538-18305-1-git-send-email-schmitz@debian.org>
[not found] ` <1387611538-18305-2-git-send-email-schmitz@debian.org>
2013-12-22 10:19 ` Fwd: " Geert Uytterhoeven
2013-12-22 11:15 ` Andreas Schwab
2013-12-23 9:16 ` Michael Schmitz
2013-12-23 11:30 ` Andreas Schwab
2013-12-23 23:36 ` Michael Schmitz
2013-12-22 11:53 ` Geert Uytterhoeven
2013-12-23 9:23 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389402091-20815-1-git-send-email-schmitz@debian.org \
--to=schmitzmic@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schmitz@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox