Re: [PATCH 1/3] m68k/atari - convert atari_scsi falcon_get_lock() to use wait_event()

schmitz
2014-03-01T23:05:43Z

Arnd ,

> On Saturday 01 March 2014, Michael Schmitz wrote:
>
>> sleep_on is known broken and going away. The atari_scsi driver is one of
>> two remaining users in the falcon_get_lock() function, which is a rather
>> crazy piece of code. This does not attempt to fix the driver's locking
>> scheme in general, but at least prevents falcon_get_lock from going to
>> sleep when no other thread holds the same lock or tries to get it,
>> and we no longer schedule with irqs disabled.
>>
>> MSch: fixed completion conditions missed in Arnds' original RFC patch.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Acked-by: Michael Schmitz <schmitz@debian.org>
>> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
>> Cc: James E.J. Bottomley <JBottomley@parallels.com>
>> Cc: linux-scsi@vger.kernel.org
>>
>
> Thanks a lot for taking care of this so quickly!
>

No matter - if I don't do it right away, chances are it won't get done
for weeks. Happens far too often.

> A minor note about patch processing: The normal way to forward
> a patch from another person is to add your 'Signed-off-by:' line
> below the one from the original submitter, i.e. in the place where
> you have the 'Acked-by:'. Not sure if you just forgot to update
> your patch or you weren't aware of that. Geert will be able to
> fix that when he adds his own Signed-off-by line.
>

I wasn't aware really - thanks.

> Also if you want to preserve authorship of the patch, you can add
> as the first line before the description a line 'From: Arnd Bergmann
> <arnd@arndb.de>'. Since you modified most the lines I originally
> changed and the patch is very small, I don't care about having
> me listed as the author, it's absolutely ok to have you listed here,
> just explaining it here in case you intended differently.
>

I think I'd prefer for you to retain ownership of the patch - by rights
it belongs into your patch series and I just did the testing. I'm
blissfully unaware of all the problems with locking and sleep_on vs.
wait_event - as the general state of the Atari NCR5380 driver probably
attests.

Can you fix that up in passing as well please, Geert?

Cheers,

Michael