From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 00/12] scsi/NCR5380: fix debugging macros and #include structure Date: Tue, 18 Mar 2014 06:20:27 -0700 Message-ID: <1395148827.2812.54.camel@joe-AO722> References: <20140318002822.372705594@telegraphics.com.au> <1395112756.20860.1.camel@joe-AO722> <1395146702.2812.47.camel@joe-AO722> <1395148051.2812.51.camel@joe-AO722> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from smtprelay0208.hostedemail.com ([216.40.44.208]:51553 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754904AbaCRNUh (ORCPT ); Tue, 18 Mar 2014 09:20:37 -0400 In-Reply-To: Sender: linux-m68k-owner@vger.kernel.org List-Id: linux-m68k@vger.kernel.org To: Geert Uytterhoeven Cc: Finn Thain , "James E.J. Bottomley" , scsi , Sam Creasey , Russell King , Michael Schmitz , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux/m68k On Tue, 2014-03-18 at 14:13 +0100, Geert Uytterhoeven wrote: > > no_printk keeps all side effects like > > performing any function calls made by the > > statement or accessing any volatiles. > That's true... > > Using > > do { if (0) no_printk(fmt, ##__VA_ARGS__); } while (0) > > does not have any side-effects. > ... but all current users in include/ have the side-effects. I believe that's intentional, but . I prefer debug statements to have _no_ side effects when not compiled-in/enabled. Opinions vary. cheers, Joe