Re: rfc: remove early_printk from a few arches? (blackfin, m68k, mips)

Måns Rullgård
2014-12-19T01:43:13Z

Joe Perches <joe@perches.com> writes:

> On Fri, 2014-12-19 at 00:33 +0100, Thomas Gleixner wrote:
>> On Wed, 17 Dec 2014, Joe Perches wrote:
>> > It seems like early_printk can be configured into
>> > a few architectures but also appear not to be used.
>> >
>> > $ git grep -w "early_printk"
>> ...
>> > These seem to the only uses:
>> ...
>> > So blackfin, m68k, and mips seems to have it possible to enable,
>> > but also don't appear at first glance to use it,
>>
>> Hint: CONFIG_EARLY_PRINTK covers far more than early_printk()
>
> I know this.
>
> Note also I didn't specify CONFIG_EARLY_PRINTK,
> just early_printk.
>
>> > Is early_printk really used by these architectures?
>> > Should it be removed?
>>
>> Sure, if you have a good reason to remove working functionality.
>
> Unused.

What exactly are you proposing to remove? I see no unused code related
to early printk (in any variant) under arch/mips.

--
Måns Rullgård
mans@mansr.com