linux-m68k.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@uclinux.org>
To: linux-m68k@vger.kernel.org
Cc: Greg Ungerer <gerg@uclinux.org>
Subject: [PATCH 01/10] m68knommu: force setting of CONFIG_CLOCK_FREQ for ColdFire
Date: Tue,  7 Jul 2015 16:55:15 +1000	[thread overview]
Message-ID: <1436252124-23051-2-git-send-email-gerg@uclinux.org> (raw)
In-Reply-To: <1436252124-23051-1-git-send-email-gerg@uclinux.org>

It is possible to disable the clock selection at configuration time,
but for ColdFire targets we always expect a clock frequency to be
selected. This results in the following compile time error:

  CC      arch/m68k/kernel/asm-offsets.s
In file included from ./arch/m68k/include/asm/timex.h:14:0,
                 from include/linux/timex.h:65,
                 from include/linux/sched.h:19,
                 from arch/m68k/kernel/asm-offsets.c:14:
./arch/m68k/include/asm/coldfire.h:25:2: error: #error "Don't know what your ColdFire CPU clock frequency is??"

Remove CONFIG_CLOCK_SELECT completely and always enable CONFIG_CLOCK_FREQ
for ColdFire.

Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
 arch/m68k/Kconfig.cpu            | 14 +-------------
 arch/m68k/include/asm/coldfire.h |  2 +-
 2 files changed, 2 insertions(+), 14 deletions(-)

diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu
index 33013df..7da5949 100644
--- a/arch/m68k/Kconfig.cpu
+++ b/arch/m68k/Kconfig.cpu
@@ -416,22 +416,10 @@ config HAVE_MBAR
 config HAVE_IPSBAR
 	bool
 
-config CLOCK_SET
-	bool "Enable setting the CPU clock frequency"
-	depends on COLDFIRE
-	default n
-	help
-	  On some CPU's you do not need to know what the core CPU clock
-	  frequency is. On these you can disable clock setting. On some
-	  traditional 68K parts, and on all ColdFire parts you need to set
-	  the appropriate CPU clock frequency. On these devices many of the
-	  onboard peripherals derive their timing from the master CPU clock
-	  frequency.
-
 config CLOCK_FREQ
 	int "Set the core clock frequency"
 	default "66666666"
-	depends on CLOCK_SET
+	depends on COLDFIRE
 	help
 	  Define the CPU clock frequency in use. This is the core clock
 	  frequency, it may or may not be the same as the external clock
diff --git a/arch/m68k/include/asm/coldfire.h b/arch/m68k/include/asm/coldfire.h
index c94557b..50aa4da 100644
--- a/arch/m68k/include/asm/coldfire.h
+++ b/arch/m68k/include/asm/coldfire.h
@@ -19,7 +19,7 @@
  *	in any case new boards come along from time to time that have yet
  *	another different clocking frequency.
  */
-#ifdef CONFIG_CLOCK_SET
+#ifdef CONFIG_CLOCK_FREQ
 #define	MCF_CLK		CONFIG_CLOCK_FREQ
 #else
 #error "Don't know what your ColdFire CPU clock frequency is??"
-- 
1.9.1

  reply	other threads:[~2015-07-07  6:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-07  6:55 [PATCH 00/10] m68knommu: fix allnoconfig Greg Ungerer
2015-07-07  6:55 ` Greg Ungerer [this message]
2015-07-07  6:55 ` [PATCH 02/10] m68knommu: improve the clock configuration defaults Greg Ungerer
2015-07-07  6:55 ` [PATCH 03/10] m68knommu: make ColdFire SoC selection a choice Greg Ungerer
2015-07-07  6:55 ` [PATCH 04/10] m68knommu: update defconfig for m5208evb Greg Ungerer
2015-07-07  6:55 ` [PATCH 05/10] m68knommu: update defconfig for ColdFire m5249evb Greg Ungerer
2015-07-07  6:55 ` [PATCH 06/10] m68knommu: update defconfig for ColdFire m5272c3 Greg Ungerer
2015-07-07  6:55 ` [PATCH 07/10] m68knommu: update defconfig for ColdFire m5275evb Greg Ungerer
2015-07-07  6:55 ` [PATCH 08/10] m68knommu: update defconfig for ColdFire m5307c3 Greg Ungerer
2015-07-07  6:55 ` [PATCH 09/10] m68knommu: update defconfig for ColdFire m5407c3 Greg Ungerer
2015-07-07  6:55 ` [PATCH 10/10] m68knommu: update defconfig for ColdFire m5475evb Greg Ungerer
2015-07-07  9:00 ` [PATCH 00/10] m68knommu: fix allnoconfig Geert Uytterhoeven
2015-07-07 12:22   ` Greg Ungerer
2015-07-07 12:45     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436252124-23051-2-git-send-email-gerg@uclinux.org \
    --to=gerg@uclinux.org \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).