public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: ahs3@redhat.com, Geert Uytterhoeven <geert@linux-m68k.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Geoff Levand <geoff@infradead.org>,
	linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org
Subject: Re: [PATCH] char: Drop bogus dependency of DEVPORT on !M68K
Date: Thu, 21 Apr 2016 11:15:17 +0200	[thread overview]
Message-ID: <1461230117.2533.8.camel@tiscali.nl> (raw)
In-Reply-To: <5717DBCE.2000303@redhat.com>

On wo, 2016-04-20 at 13:43 -0600, Al Stone wrote:
> On 04/11/2016 02:40 AM, Geert Uytterhoeven wrote:
> > --- a/drivers/char/Kconfig
> > +++ b/drivers/char/Kconfig

> > config DEVPORT
> >  	bool
> > -	depends on !M68K
> >  	depends on ISA || PCI
> >  	default y

> This solves the particular problem I was running into on an arm64 AMD Seattle
> system.  Thanks!

That problem must be 
lkml.kernel.org/g/1459978040-2226-1-git-send-email-ahs3@redhat.com . Ie,
the fact that CONFIG_DEVPORT "cannot really be used and it allows us to
crash a kernel from user space" on arm64. 

> Tested-by: Al Stone <ahs3@redhat.com>

I fail to see how this patch helps your problem. And if one applies this
patch on top of v4.6-rc4 and does
    make ARCH=arm64 defconfig

one gets a .config that still has
    CONFIG_DEVPORT=y

So my guess is that it wasn't this patch that solved that arm64 problem.

Thanks,


Paul Bolle

  reply	other threads:[~2016-04-21  9:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1460364055-10174-1-git-send-email-geert@linux-m68k.org>
2016-04-20 19:43 ` [PATCH] char: Drop bogus dependency of DEVPORT on !M68K Al Stone
2016-04-21  9:15   ` Paul Bolle [this message]
2016-04-11  8:40 Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461230117.2533.8.camel@tiscali.nl \
    --to=pebolle@tiscali.nl \
    --cc=ahs3@redhat.com \
    --cc=arnd@arndb.de \
    --cc=geert@linux-m68k.org \
    --cc=geoff@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox