Re: [PATCH 7/8] m68k: only generate FPU instructions of CONFIG_FPU

Geert Uytterhoeven
2016-08-29T12:53:06Z

Hi Greg,

On Mon, Aug 29, 2016 at 1:43 PM, Greg Ungerer <gerg@linux-m68k.org> wrote:
> Most of the m68k code that supports a hardware FPU is surrounded by
> CONFIG_FPU. Except this setup code in setup_mm.c. Be consistent and
> surround these hardware FPU instructions with CONFIG_FPU instead of
> a check based on CONFIG_M68KFPU_EMU_ONLY.
>
> The side effect of this is that we can now compile a kernel with no
> m68k/ColdFire hardware support FPU instructions at all (if we do not
> define CONFIG_FPU).
>
> Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>
> ---
> arch/m68k/kernel/setup_mm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/m68k/kernel/setup_mm.c b/arch/m68k/kernel/setup_mm.c
> index 13f4640..00290c4 100644
> --- a/arch/m68k/kernel/setup_mm.c
> +++ b/arch/m68k/kernel/setup_mm.c
> @@ -245,7 +245,7 @@ void __init setup_arch(char **cmdline_p)
> * We should really do our own FPU check at startup.
> * [what do we do with buggy 68LC040s? if we have problems
> * with them, we should add a test to check_bugs() below] */
> -#ifndef CONFIG_M68KFPU_EMU_ONLY
> +#ifdef CONFIG_FPU
> /* clear the fpu if we have one */
> if (m68k_fputype & (FPU_68881|FPU_68882|FPU_68040|FPU_68060|FPU_COLDFIRE)) {
> volatile int zero = 0;

This piece of code is now compiled in if CONFIG_M68KFPU_EMU_ONLY=y?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds