Re: [PATCH RFC 2/2] net/8390: apne.c - add 100 Mbit support to apne.c driver

ALeX Kazik
2021-06-07T08:47:33Z

Hi all,

> It's been quite a while - can you still try and build/test this change, Alex?

I'm happy to test it again (assuming my Amiga still works, not used
for a while).
But I'm waiting until you guys have perfected the patch.

> >> +
> >> pr_info("Looking for PCMCIA ethernet card : ");
> >>
> >> /* check if a card is inserted */
> >> @@ -590,6 +597,16 @@ static int init_pcmcia(void)
> >> #endif
> >> u_long offset;
> >>
> >> +#ifdef CONFIG_APNE100MBIT
> >> + /* reset card (idea taken from CardReset by Artur Pogoda) */
> >> + {
> >> + u_char tmp = gayle.intreq;
> >> +
> >> + gayle.intreq = 0xff; mdelay(1);
> >> + gayle.intreq = tmp; mdelay(300);
> >> + }
> >
> > Is this safe for all cards?
>
> I _think_ so, but this really is a question for Alex and others involved
> in developing the original patch. (The original patch had that
> conditionalized as well so I might be wrong ...)

My code is based on the patches here: http://www.g-mb.de/pcmcia_e.html

I'm not deep into it, just adapted the patch. And that's why I can't
tell if the other drivers will work with it always enabled, sorry.

Bye,
Alex.