Re: [PATCH v2] m68k: io_mm.h: conditionalize ISA address translation on Atari

Michael Schmitz
2021-06-09T21:45:07Z

Hi Andreas,

On 9/06/21 7:57 pm, Andreas Schwab wrote:
> On Jun 09 2021, Michael Schmitz wrote:
>
>> @@ -135,10 +139,13 @@ static inline u8 __iomem *isa_itb(unsigned long addr)
>> case ISA_TYPE_AG: return (u8 __iomem *)AG_ISA_IO_B(addr);
>> #endif
>> #ifdef CONFIG_ATARI_ROM_ISA
>> - case ISA_TYPE_ENEC: return (u8 __iomem *)ENEC_ISA_IO_B(addr);
>> + case ISA_TYPE_ENEC:
>> + if (addr < 1024)
>> + return (u8 __iomem *)ENEC_ISA_IO_B(addr);
>> + break; /* not ROM port? fallback below! */
>> #endif
>> - default: return NULL; /* avoid warnings, just in case */
>> }
>> + return (u8 __iomem *)(addr); /* avoid warnings, just in case */
> I don't think the comment still fits here.

True - I'll remove it.

Cheers,

Michael

>
> Andreas.
>