Re: [PATCH RFC 2/2] net/8390: apne.c - add 100 Mbit support to apne.c driver

Michael Schmitz
2021-06-08T03:11:47Z

Hi Alex,

Am 07.06.2021 um 20:46 schrieb ALeX Kazik:
> Hi all,
>
>> It's been quite a while - can you still try and build/test this change, Alex?
>
> I'm happy to test it again (assuming my Amiga still works, not used
> for a while).
> But I'm waiting until you guys have perfected the patch.

Thanks, I'll keep you in the CC list.
>
>>>> +
>>>> pr_info("Looking for PCMCIA ethernet card : ");
>>>>
>>>> /* check if a card is inserted */
>>>> @@ -590,6 +597,16 @@ static int init_pcmcia(void)
>>>> #endif
>>>> u_long offset;
>>>>
>>>> +#ifdef CONFIG_APNE100MBIT
>>>> + /* reset card (idea taken from CardReset by Artur Pogoda) */
>>>> + {
>>>> + u_char tmp = gayle.intreq;
>>>> +
>>>> + gayle.intreq = 0xff; mdelay(1);
>>>> + gayle.intreq = tmp; mdelay(300);
>>>> + }
>>>
>>> Is this safe for all cards?
>>
>> I _think_ so, but this really is a question for Alex and others involved
>> in developing the original patch. (The original patch had that
>> conditionalized as well so I might be wrong ...)
>
> My code is based on the patches here: http://www.g-mb.de/pcmcia_e.html
>
> I'm not deep into it, just adapted the patch. And that's why I can't
> tell if the other drivers will work with it always enabled, sorry.

According to that site, the reset is needed for all 100 Mbit cards, and
in your patch from 2018, you mentioned that this is because the PCMCIA
reset line isn't connected on these cards. Based on that reading, this
_should_ be safe for those cards that have a reset line wired as well.

Who could we ask - I guess Rolf Anders was the author of a previous
patch for the 100 Mbit APNE compatible cards? Not sure I've seen an
e-mail address for Artur Pogoda?

Cheers,

Michael

>
> Bye,
> Alex.
>