From: Florian Fainelli <f.fainelli@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-clk@vger.kernel.org
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Ralf Baechle <ralf@linux-mips.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-mips@linux-mips.org,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Eric Miao <eric.y.miao@gmail.com>,
linux-kernel@vger.kernel.org,
adi-buildroot-devel@lists.sourceforge.net,
Greg Ungerer <gerg@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org,
bcm-kernel-feedback-list@broadcom.com,
Wan ZongShun <mcuos.com@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Steven Miao <realmz6@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] clk: let clk_disable() return immediately if clk is NULL
Date: Thu, 25 Aug 2016 08:27:07 -0700 [thread overview]
Message-ID: <194aebe5-38dd-f43d-fb4d-16ce592a68e8@gmail.com> (raw)
In-Reply-To: <1472059613-30551-1-git-send-email-yamada.masahiro@socionext.com>
On 08/24/2016 10:26 AM, Masahiro Yamada wrote:
> Many of clk_disable() implementations just return for NULL pointer,
> but this check is missing from some. Let's make it tree-wide
> consistent. It will allow clock consumers to call clk_disable()
> without NULL pointer check.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Acked-by: Greg Ungerer <gerg@uclinux.org>
> Acked-by: Wan Zongshun <mcuos.com@gmail.com>
> ---
>
> I came back after a long pause.
> You can see the discussion about the previous version:
> https://www.linux-mips.org/archives/linux-mips/2016-04/msg00063.html
>
>
> Changes in v3:
> - Return only when clk is NULL. Do not take care of error pointer.
>
> Changes in v2:
> - Rebase on Linux 4.6-rc1
>
> arch/arm/mach-mmp/clock.c | 3 +++
> arch/arm/mach-w90x900/clock.c | 3 +++
> arch/blackfin/mach-bf609/clock.c | 3 +++
> arch/m68k/coldfire/clk.c | 4 ++++
> arch/mips/bcm63xx/clk.c | 3 +++
For bcm63xx:
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2016-08-25 15:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1472059613-30551-1-git-send-email-yamada.masahiro@socionext.com>
2016-08-25 7:52 ` [PATCH v3] clk: let clk_disable() return immediately if clk is NULL Geert Uytterhoeven
2016-08-25 15:27 ` Florian Fainelli [this message]
2016-09-16 7:44 ` Masahiro Yamada
[not found] ` <CAK7LNARaV6Ga5G1GnYf9hywrr+YwOqqm-v1AzBpfXtM4u9ofBA@mail.gmail.com>
2016-09-16 23:11 ` Stephen Boyd
2016-08-24 17:26 Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=194aebe5-38dd-f43d-fb4d-16ce592a68e8@gmail.com \
--to=f.fainelli@gmail.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=eric.y.miao@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@linux-mips.org \
--cc=linux@armlinux.org.uk \
--cc=mcuos.com@gmail.com \
--cc=mturquette@baylibre.com \
--cc=ralf@linux-mips.org \
--cc=realmz6@gmail.com \
--cc=sboyd@codeaurora.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox