From: Michael Schmitz <schmitzmic@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux/m68k <linux-m68k@vger.kernel.org>, ALeX Kazik <alex@kazik.de>
Subject: Re: [PATCH v10 1/3] m68k: amiga/pcmcia - add 16 bit detection interface to amipcmcia.h
Date: Sat, 13 Nov 2021 16:00:57 +1300 [thread overview]
Message-ID: <1b1ccd18-0c75-c8f5-4a60-5cefb0f0cae7@gmail.com> (raw)
In-Reply-To: <CAMuHMdWqUO5xBp+sbOJrAGRPA+4YqZNuXjypdHi8R3fkQ9Ufxw@mail.gmail.com>
Hi Geert,
On 12/11/21 23:33, Geert Uytterhoeven wrote:
> Hi Michael,
>
> On Thu, Nov 11, 2021 at 3:56 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
>> Add the interface definition for 16 bit card autoprobing (using
>> the generic PCMCIA cftable entry parser) to amipcmcia.h for use
>> by apne.c. Include necessary cftable definitions from cistpl.h,
>> remove locally duplicate definitions from amipcmcia.h.
>>
>> Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
>
> Thanks for your patch!
>
>> --- a/arch/m68k/include/asm/amipcmcia.h
>> +++ b/arch/m68k/include/asm/amipcmcia.h
>> @@ -13,6 +13,7 @@
>> #ifndef __AMIGA_PCMCIA_H__
>> #define __AMIGA_PCMCIA_H__
>>
>> +#include <pcmcia/cistpl.h>
>> #include <asm/amigayle.h>
>>
>> /* prototypes */
>> @@ -64,47 +65,8 @@ static inline void pcmcia_disable_irq(void)
>> #define PCMCIA_SPEED_250NS 250
>> #define PCMCIA_SPEED_720NS 720
>>
>> -/* PCMCIA Tuple codes */
>> -
>> -#define CISTPL_NULL 0x00
>> -#define CISTPL_DEVICE 0x01
>> -#define CISTPL_LONGLINK_CB 0x02
>> -#define CISTPL_CONFIG_CB 0x04
>> -#define CISTPL_CFTABLE_ENTRY_CB 0x05
>> -#define CISTPL_LONGLINK_MFC 0x06
>> -#define CISTPL_BAR 0x07
>> -#define CISTPL_CHECKSUM 0x10
>> -#define CISTPL_LONGLINK_A 0x11
>> -#define CISTPL_LONGLINK_C 0x12
>> -#define CISTPL_LINKTARGET 0x13
>> -#define CISTPL_NO_LINK 0x14
>> -#define CISTPL_VERS_1 0x15
>> -#define CISTPL_ALTSTR 0x16
>> -#define CISTPL_DEVICE_A 0x17
>> -#define CISTPL_JEDEC_C 0x18
>> -#define CISTPL_JEDEC_A 0x19
>> -#define CISTPL_CONFIG 0x1a
>> -#define CISTPL_CFTABLE_ENTRY 0x1b
>> -#define CISTPL_DEVICE_OC 0x1c
>> -#define CISTPL_DEVICE_OA 0x1d
>> -#define CISTPL_DEVICE_GEO 0x1e
>> -#define CISTPL_DEVICE_GEO_A 0x1f
>> -#define CISTPL_MANFID 0x20
>> -#define CISTPL_FUNCID 0x21
>> -#define CISTPL_FUNCE 0x22
>> -#define CISTPL_SWIL 0x23
>> -#define CISTPL_END 0xff
>> -
>> -/* FUNCID */
>> -
>> -#define CISTPL_FUNCID_MULTI 0x00
>> -#define CISTPL_FUNCID_MEMORY 0x01
>> -#define CISTPL_FUNCID_SERIAL 0x02
>> -#define CISTPL_FUNCID_PARALLEL 0x03
>> -#define CISTPL_FUNCID_FIXED 0x04
>> -#define CISTPL_FUNCID_VIDEO 0x05
>> -#define CISTPL_FUNCID_NETWORK 0x06
>> -#define CISTPL_FUNCID_AIMS 0x07
>> -#define CISTPL_FUNCID_SCSI 0x08
>> +/* CIS tuple parser for 16 bit IO detection */
>> +
>> +extern int pcmcia_parse_tuple(tuple_t *cftuple, cisparse_t *cfparse);
>
> Seems like you can just #include <pcmcia/ds.h> instead, no ill
> effects on .i and .s output?
Too true - will do that instead.
Cheers,
Michael
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
next prev parent reply other threads:[~2021-11-13 3:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 2:55 [PATCH v10 0/3] Add APNE PCMCIA 100 Mbit support Michael Schmitz
2021-11-11 2:55 ` [PATCH v10 1/3] m68k: amiga/pcmcia - add 16 bit detection interface to amipcmcia.h Michael Schmitz
2021-11-12 10:33 ` Geert Uytterhoeven
2021-11-13 3:00 ` Michael Schmitz [this message]
2021-11-11 2:55 ` [PATCH v10 2/3] m68k: io_mm.h - add APNE 100 MBit support Michael Schmitz
2021-11-11 2:55 ` [PATCH net v10 3/3] net/8390: apne.c - add 100 Mbit support to apne.c driver Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b1ccd18-0c75-c8f5-4a60-5cefb0f0cae7@gmail.com \
--to=schmitzmic@gmail.com \
--cc=alex@kazik.de \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox