From: Ingo Molnar <mingo@elte.hu>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH] tracing: fix a build error on alpha and m68k
Date: Fri, 31 Oct 2008 10:55:44 +0100 [thread overview]
Message-ID: <20081031095544.GI30317@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.64.0810310949190.22521@anakin>
* Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Fri, 31 Oct 2008, Alexey Dobriyan wrote:
> > On Thu, Oct 23, 2008 at 08:34:33PM +0400, Alexey Dobriyan wrote:
> > > On Thu, Oct 23, 2008 at 07:27:48PM +0200, Frederic Weisbecker wrote:
> > > > When tracing is enabled, some arch have included <linux/irqflags.h>
> > > > on their <asm/system.h> but others like alpha or m68k don't.
> > > >
> > > > Build error on alpha:
> > > >
> > > > kernel/trace/trace.c: In function 'tracing_generic_entry_update':
> > > > kernel/trace/trace.c:658: error: implicit declaration of function 'irqs_disabled_flags'
> >
> > FYI, this error still exists in mainline (7f82f000ed030d1108b4de47d9e2d556092980c6).
>
> Now it hit mainline (I can't be bothered to develop _new_ code to
> fix things in -next ;-), I'm implementing irqs_disabled_flags() for
> m68k. Stay tuned...
this (now mainline) commit should have fixed it:
9244489: ftrace: handle archs that do not support irqs_disabled_flags
can you still see problems?
Ingo
next prev parent reply other threads:[~2008-10-31 9:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081023213637.eff9b414.sfr@canb.auug.org.au>
[not found] ` <20081023121145.GB27984@x200.localdomain>
[not found] ` <c62985530810230548t1b569f61g34d1900bb94fde83@mail.gmail.com>
[not found] ` <c62985530810230615s3252a54ao6488e763d72dc939@mail.gmail.com>
[not found] ` <49008D12.5090204@gmail.com>
[not found] ` <Pine.LNX.4.64.0810231635440.18978@anakin>
[not found] ` <c62985530810230757r411b4e3dj4ecec649cf8cf0b3@mail.gmail.com>
[not found] ` <Pine.LNX.4.64.0810231727430.18978@anakin>
[not found] ` <4900B414.7090002@gmail.com>
[not found] ` <20081023163433.GA3160@x200.localdomain>
[not found] ` <20081023163850.GB16591@elte.hu>
[not found] ` <4901D8CD.7000405@gmail.com>
[not found] ` <alpine.DEB.1.10.0810240937130.3882@gandalf.stny.rr.com>
2008-10-25 8:24 ` [PATCH] ftrace: handle archs that do not support irqs_disabled_flags Geert Uytterhoeven
2008-10-28 7:25 ` Greg Ungerer
[not found] ` <20081030214910.GA14679@x200.localdomain>
2008-10-31 8:50 ` [PATCH] tracing: fix a build error on alpha and m68k Geert Uytterhoeven
2008-10-31 9:55 ` Ingo Molnar [this message]
2008-11-01 10:16 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081031095544.GI30317@elte.hu \
--to=mingo@elte.hu \
--cc=adobriyan@gmail.com \
--cc=fweisbec@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox