From: Brad Boyer <flar@allandria.com>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: Laurent@lvivier.info, geert@linux-m68k.org, linux-m68k@vger.kernel.org
Subject: Re: [PATCH] Add SWIM floppy support for m68k Macs.
Date: Sat, 1 Nov 2008 22:23:23 -0700 [thread overview]
Message-ID: <20081102052323.GA32207@cynthia.pants.nu> (raw)
In-Reply-To: <Pine.LNX.4.64.0811021103400.26989@loopy.telegraphics.com.au>
On Sun, Nov 02, 2008 at 11:29:54AM +1100, Finn Thain wrote:
> I think that unless we can probe for the SWIM chip, we should put this
> information in arch/m68k/mac/config.c. A floppy_type member could be added
> to struct mac_model to clean up the init code here. That init code could
> then simply test macintosh_config like all the other drivers that can't or
> don't probe.
I didn't think about it when I commented earlier, but I agree with this
suggestion. I think there are 5 types we need to put in the table:
MAC_FLOPPY_IWM
MAC_FLOPPY_SWIM_ADDR1
MAC_FLOPPY_SWIM_ADDR2
MAC_FLOPPY_SWIM_IOP
MAC_FLOPPY_AV
We don't have to use this exact naming, but this is the basic categories,
and this driver should handle number 2 and 3 (and maybe 1).
Brad Boyer
flar@allandria.com
next prev parent reply other threads:[~2008-11-02 5:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-01 9:43 [PATCH] Add SWIM floppy support for m68k Macs Laurent
2008-11-01 18:10 ` Brad Boyer
2008-11-02 0:29 ` Finn Thain
2008-11-02 5:23 ` Brad Boyer [this message]
2008-11-02 12:02 ` Laurent Vivier
2008-11-04 18:34 ` Riccardo
2008-11-04 20:06 ` Brad Boyer
2008-11-05 0:58 ` Riccardo
2008-11-05 2:28 ` Brad Boyer
2008-11-05 21:43 ` Riccardo
2008-11-06 4:18 ` Brad Boyer
2008-11-05 6:58 ` Finn Thain
2008-11-05 21:45 ` Riccardo
2008-11-05 7:37 ` Joshua Juran
2008-11-05 10:31 ` Finn Thain
2008-11-05 12:20 ` Joshua Juran
2008-11-05 13:10 ` Finn Thain
2008-11-05 14:32 ` Laurent Vivier
2008-11-06 4:09 ` Brad Boyer
2008-11-02 6:00 ` Finn Thain
2008-11-02 11:59 ` Laurent Vivier
2008-11-02 8:54 ` Geert Uytterhoeven
2008-11-02 11:21 ` Laurent Vivier
2008-11-02 21:28 ` Brad Boyer
2008-11-03 0:14 ` Finn Thain
2008-11-03 18:58 ` Laurent Vivier
2008-11-09 16:16 ` Geert Uytterhoeven
2008-11-09 21:47 ` Laurent Vivier
2008-11-09 23:05 ` Michael Schmitz
2008-11-10 0:15 ` Finn Thain
2008-11-11 8:52 ` Geert Uytterhoeven
2008-11-11 9:43 ` Finn Thain
2008-11-11 10:21 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081102052323.GA32207@cynthia.pants.nu \
--to=flar@allandria.com \
--cc=Laurent@lvivier.info \
--cc=fthain@telegraphics.com.au \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox