From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Roman Zippel <zippel@linux-m68k.org>,
linux-m68k <linux-m68k@vger.kernel.org>,
Greg Ungerer <gerg@uclinux.org>,
uclinux-dev <uclinux-dev@uclinux.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: Re: Merge headerfiles for m68k and m68knommu to arch/m68k/include/asm
Date: Tue, 9 Dec 2008 00:26:05 +0100 [thread overview]
Message-ID: <200812090026.06689.arnd@arndb.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0812082359190.29640@anakin>
On Tuesday 09 December 2008, Geert Uytterhoeven wrote:
> > I have used the following include guard:
> >
> > #ifdef __uClinux__
> > #include "atomic_no.h"
> > #else
> > #include "atomic_mm.h"
> > #endif
> >
> > gcc -E -dM for the two compilers revealed that this was the
> > only symbol that differed.
>
> I think you can share a toolchain for m68k and m68knommu, at least for the
> kernel (I used my plain m68k toolchain when experimenting with m68knommu for
> Amiga).
>
> > With the above construct we do the "right thing" also for
> > headers exported to userspace.
> > But actually none of the headers using the above are
> > subject for export at the moment so we could use a
> > CONFIG_ symbol for the same.
>
> So I prefer to just check CONFIG_MMU.
Some of them are, by means of include/asm-generic/Kbuild.asm, e.g.
unistd.h!
I'm not sure if it's entirely correct, but I think you can use
#ifdef __KERNEL__
# ifdef CONFIG_MMU
# include "atomic_mm.h
# else
# include "atomic_no.h
# endif
#else
# ifndef __uClinux__
# include "atomic_mm.h
# else
# include "atomic_no.h
# endif
#endif
Arnd <><
next prev parent reply other threads:[~2008-12-08 23:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081208205814.GA22697@uranus.ravnborg.org>
2008-12-08 22:53 ` Merge headerfiles for m68k and m68knommu to arch/m68k/include/asm Sam Ravnborg
2008-12-08 23:01 ` Geert Uytterhoeven
2008-12-08 23:26 ` Arnd Bergmann [this message]
2008-12-09 5:45 ` Sam Ravnborg
2008-12-09 8:24 ` Geert Uytterhoeven
2008-12-09 9:45 ` Andreas Schwab
2008-12-09 11:02 ` Arnd Bergmann
2008-12-09 18:04 ` Sam Ravnborg
2008-12-11 8:33 ` Geert Uytterhoeven
2008-12-11 9:38 ` Andreas Schwab
2008-12-11 16:48 ` Arnd Bergmann
2008-12-11 20:16 ` Geert Uytterhoeven
2008-12-13 16:16 ` Arnd Bergmann
2008-12-12 5:40 ` Greg Ungerer
2008-12-13 20:46 ` Sam Ravnborg
2008-12-13 20:43 ` Sam Ravnborg
2008-12-09 16:54 ` Allon Stern
2008-12-09 17:39 ` [uClinux-dev] " Geert Uytterhoeven
2008-12-11 15:44 ` Allon Stern
2008-12-12 5:22 ` Greg Ungerer
2008-12-13 20:52 ` Sam Ravnborg
[not found] ` <20081213205251.GC27748@uranus.ravnborg.org>
[not found] ` <20081213205828.GD27748@uranus.ravnborg.org>
2008-12-14 16:13 ` [PATCH] m68k,m68knommu: merge header files Geert Uytterhoeven
[not found] ` <49707AE0.1040803@opengear.com>
2009-01-16 12:57 ` Geert Uytterhoeven
2009-01-16 14:21 ` Greg Ungerer
2009-01-16 14:34 ` Sam Ravnborg
2009-01-16 21:53 ` Geert Uytterhoeven
2009-01-16 22:19 ` Greg Ungerer
2008-12-08 20:58 Merge headerfiles for m68k and m68knommu to arch/m68k/include/asm Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812090026.06689.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=gerg@uclinux.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=uclinux-dev@uclinux.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox