Re: [patch 6/6] fbdev: c2p - Rename c2p to c2p_planar and correct indentation

Andrew Morton
2008-12-22T23:24:22Z

On Sun, 21 Dec 2008 16:01:05 +0100
Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> + /*
> + * Store a full block of planar data after c2p conversion
> + */
> +
> +static inline void store_planar(void *dst, u32 dst_inc, u32 bpp, u32 d[8])
> +{
> + int i;
> +
> + for (i = 0; i < bpp; i++, dst += dst_inc)
> + *(u32 *)dst = d[perm_c2p_32x8[i]];
> +}
> +
> +
> + /*
> + * Store a partial block of planar data after c2p conversion
> + */
> +
> +static inline void store_planar_masked(void *dst, u32 dst_inc, u32 bpp,
> + u32 d[8], u32 mask)
> +{
> + int i;
> +
> + for (i = 0; i < bpp; i++, dst += dst_inc)
> + *(u32 *)dst = comp(d[perm_c2p_32x8[i]], *(u32 *)dst, mask);
> +}

Why not just make the first arg of these (too large to be inlined)
functions have type u32*, then do away with the casts?