From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: rtc-linux@googlegroups.com
Cc: Geert.Uytterhoeven@sonycom.com, Kyle McMartin <kyle@mcmartin.ca>,
linux-parisc@vger.kernel.org, linuxppc-dev@ozlabs.org,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
Paul Mundt <lethal@linux-sh.org>, Dann Frazier <dannf@dannf.org>,
Geoff Levand <geoffrey.levand@am.sony.com>
Subject: Re: [rtc-linux] [PATCH 7/7] powerpc/ps3: Add rtc-ps3
Date: Mon, 9 Mar 2009 15:12:16 +0100 [thread overview]
Message-ID: <20090309151216.17f13862@i1501.lan.towertech.it> (raw)
In-Reply-To: <1236605183-22718-8-git-send-email-Geert.Uytterhoeven@sonycom.com>
On Mon, 9 Mar 2009 14:26:23 +0100
Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> wrote:
Hi,
just a few notes:
> +
> +static int ps3_get_time(struct device *dev, struct rtc_time *tm)
> +{
> + to_tm(read_rtc() + ps3_os_area_get_rtc_diff(), tm);
> + tm->tm_year -= 1900;
> + tm->tm_mon -= 1;
> + return 0;
> +}
this should be return rtc_valid_tm() .
can't you use functions from rtc-lib.c instead of
that to_tm ?
> +
> +MODULE_AUTHOR("Sony Corporation");
real name, if possible and a contact address
here . Just in case I need someone to bother :)
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
next prev parent reply other threads:[~2009-03-09 14:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-09 13:26 [PATCH 0/7] Generic RTC class driver Geert Uytterhoeven
2009-03-09 13:26 ` [PATCH 1/7] parisc: rtc: get_rtc_time() returns unsigned int Geert Uytterhoeven
2009-03-09 13:26 ` [PATCH 2/7] parisc: rtc: platform_driver_probe() fixups Geert Uytterhoeven
2009-03-09 13:26 ` [PATCH 3/7] parisc: rtc: Add missing module alias Geert Uytterhoeven
2009-03-09 13:26 ` [PATCH 4/7] parisc: rtc: Rename rtc-parisc to rtc-generic Geert Uytterhoeven
2009-03-09 13:26 ` [PATCH 5/7] m68k: Hook up rtc-generic Geert Uytterhoeven
2009-03-09 13:26 ` [PATCH 6/7] powerpc: Hook up rtc-generic, and kill rtc-ppc Geert Uytterhoeven
2009-03-09 13:26 ` [PATCH 7/7] powerpc/ps3: Add rtc-ps3 Geert Uytterhoeven
2009-03-09 14:12 ` Alessandro Zummo [this message]
2009-03-09 15:24 ` [rtc-linux] " Geert Uytterhoeven
2009-03-09 18:04 ` Geoff Levand
2009-03-09 18:43 ` [rtc-linux] " Alessandro Zummo
2009-03-09 19:06 ` Geoff Levand
2009-03-09 19:18 ` Joe Perches
2009-03-09 18:35 ` Geoff Levand
2009-03-10 9:21 ` Geert Uytterhoeven
2009-03-10 16:18 ` Geoff Levand
2009-03-09 13:59 ` [PATCH 6/7] powerpc: Hook up rtc-generic, and kill rtc-ppc David Woodhouse
2009-03-11 4:15 ` Benjamin Herrenschmidt
2009-03-16 13:09 ` [PATCH 4/7] parisc: rtc: Rename rtc-parisc to rtc-generic Christoph Hellwig
2009-03-09 14:14 ` [rtc-linux] [PATCH 0/7] Generic RTC class driver Alessandro Zummo
2009-03-09 15:46 ` Paul Mundt
2009-03-11 10:36 ` Geert Uytterhoeven
2009-03-11 15:45 ` Kyle McMartin
2009-03-11 17:26 ` Geert Uytterhoeven
2009-03-13 4:25 ` Kyle McMartin
2009-04-02 9:42 ` Geert Uytterhoeven
2009-04-02 13:56 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090309151216.17f13862@i1501.lan.towertech.it \
--to=alessandro.zummo@towertech.it \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=dannf@dannf.org \
--cc=geoffrey.levand@am.sony.com \
--cc=kyle@mcmartin.ca \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox