From: David Miller <davem@davemloft.net>
To: fthain@telegraphics.com.au
Cc: joe@perches.com, p_gortmaker@yahoo.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org
Subject: Re: [PATCH] mac8390: fix pr_info() calls and change return code
Date: Thu, 15 Apr 2010 22:53:43 -0700 (PDT) [thread overview]
Message-ID: <20100415.225343.266704449.davem@davemloft.net> (raw)
In-Reply-To: <alpine.OSX.2.00.1004161403160.271@localhost>
From: Finn Thain <fthain@telegraphics.com.au>
Date: Fri, 16 Apr 2010 14:21:00 +1000 (EST)
>
> @@ -668,11 +668,11 @@
> {
> unsigned char *target = nubus_slot_addr(IRQ2SLOT(dev->irq));
> if (ei_debug > 1)
> - pr_info("Need to reset the NS8390 t=%lu...", jiffies);
> + printk(KERN_DEBUG "Need to reset the NS8390 t=%lu...", jiffies);
> ei_status.txing = 0;
> target[0xC0000] = 0;
> if (ei_debug > 1)
> - pr_cont("reset complete\n");
> + printk(KERN_CONT "reset complete\n");
> return;
You're missing the whole point of using pr_info() et al. in that it
includes the bits we define for pr_fmt at the top of the file.
Also, you write absolutely no commit log message entry for your
change explaining why you're doing the things you are doing.
And finally you are doing two completely unrelated things at one
(changing error return values and changing log message levels).
next prev parent reply other threads:[~2010-04-16 5:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 2:34 another cleanup patch gone wrong Finn Thain
2010-04-16 3:01 ` David Miller
2010-04-16 3:45 ` [PATCH] mac8390: fix pr_info() calls, was " Finn Thain
2010-04-16 3:54 ` Joe Perches
2010-04-16 3:59 ` Finn Thain
2010-04-16 4:21 ` [PATCH] mac8390: fix pr_info() calls and change return code Finn Thain
2010-04-16 4:34 ` Joe Perches
2010-04-16 13:57 ` Finn Thain
2010-04-16 20:28 ` David Miller
2010-04-17 2:28 ` Finn Thain
2010-04-16 5:53 ` David Miller [this message]
2010-04-16 14:14 ` [PATCH] mac8390: change an error return code and some cleanup Finn Thain
2010-04-17 3:16 ` [PATCH] mac8390: change an error return code and some cleanup, take 3 Finn Thain
2010-04-21 23:30 ` David Miller
2010-04-22 1:13 ` Finn Thain
2010-05-28 17:29 ` [PATCH] mac8390: change an error return code and some cleanup, take 4 Finn Thain
2010-05-31 7:19 ` David Miller
2010-05-31 9:21 ` fthain
2010-05-31 9:58 ` Geert Uytterhoeven
2010-05-31 11:07 ` fthain
2010-05-31 11:30 ` David Miller
2010-05-31 12:55 ` Finn Thain
2010-05-31 13:02 ` David Miller
2010-06-01 12:18 ` [PATCH 1/2] mac8390: propagate error code from request_irq Finn Thain
2010-06-02 12:17 ` David Miller
2010-06-01 12:18 ` [PATCH 2/2] mac8390: raise error logging priority Finn Thain
2010-06-02 14:06 ` David Miller
2010-06-02 15:36 ` Finn Thain
2010-05-31 15:08 ` [PATCH] mac8390: change an error return code and some cleanup, take 4 Joe Perches
2010-05-31 15:14 ` David Miller
2010-05-31 15:19 ` Finn Thain
2010-05-31 11:27 ` David Miller
2010-04-16 3:11 ` another cleanup patch gone wrong Joe Perches
2010-04-16 3:21 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100415.225343.266704449.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fthain@telegraphics.com.au \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox