Re: [PATCH] mac8390: change an error return code and some cleanup, take 4

fthain
2010-05-31T09:31:22Z

On Mon, 31 May 2010, David Miller wrote:

> This is getting tiring Finn.

I agree. My patch addresses all of the criticism of the earlier
submissions.

To make it plain: there are 25 files or so that use ei_debug. Three of
those that now have the KERN_DEBUG printk's suppresed by the DEBUG macro
only do so as an apparently unintended side effect of a commit that claims
to "implement dynmic debug infrastructure". (Go figure.)

http://git.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=commitdiff;h=dd0fab5b940c0b65f26ac5b01485bac1f690ace6

Your suggestion to use pr_debug is invoking compile time infrastructure
(the DEBUG macro), so it is not in the spirit of this commit, and it is
not relevant to any criticism from you or Joe of the earlier submissions.

Please apply the patch.

Finn