From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: Early crash (was: Re: module: show version information for built-in modules in sysfs) Date: Tue, 1 Feb 2011 14:26:37 -0800 Message-ID: <20110201222637.GA17521@dtor-ws.eng.vmware.com> References: <20110201210944.GA12348@dtor-ws.eng.vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from smtp-outbound-1.vmware.com ([65.115.85.69]:22013 "EHLO smtp-outbound-1.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998Ab1BAW0h (ORCPT ); Tue, 1 Feb 2011 17:26:37 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-m68k-owner@vger.kernel.org List-Id: linux-m68k@vger.kernel.org To: Geert Uytterhoeven Cc: Rusty Russell , "linux-kernel@vger.kernel.org" , Linux/m68k On Tue, Feb 01, 2011 at 02:03:23PM -0800, Geert Uytterhoeven wrote: > On Tue, Feb 1, 2011 at 22:09, Dmitry Torokhov wrote= : > > On Tue, Feb 01, 2011 at 12:33:29PM -0800, Geert Uytterhoeven wrote: > >> On Mon, Jan 24, 2011 at 11:59, Linux Kernel Mailing List > >> wrote: > >> > Gitweb: =A0 =A0 http://git.kernel.org/linus/e94965ed5beb23c6fabf= 7ed31f625e66d7ff28de > >> > >> > =A0 =A0module: show version information for built-in modules in = sysfs > >> > > >> > =A0 =A0Currently only drivers that are built as modules have the= ir versions > >> > =A0 =A0shown in /sys/module//version, but this info= rmation might > >> > =A0 =A0also be useful for built-in drivers as well. This especia= lly important > >> > =A0 =A0for drivers that do not define any parameters - such driv= ers, if > >> > =A0 =A0built-in, are completely invisible from userspace. > >> > > >> > =A0 =A0This patch changes MODULE_VERSION() macro so that in case= when we are > >> > =A0 =A0compiling built-in module, version information is stored = in a separate > >> > =A0 =A0section. Kernel then uses this data to create 'version' s= ysfs attribute > >> > =A0 =A0in the same fashion it creates attributes for module para= meters. > >> > >> This commit causes the crash below on m68k (ARAnyM). > >> Reverting this commit and its dependency > >> 3b90a5b292321b2acac3921f77046ae195aef53f > >> ("module: fix linker error for MODULE_VERSION when !MODULE and CON= =46IG_SYSFS=3Dn") > >> makes it boot again. > >> > > > > Hi Geert, > > > > Does the follwing help by any chance? > > > > From d6fd4a6e0fc2d3f0a74962d4a6f663a46d230ecd Mon Sep 17 00:00:00 2= 001 > > diff --git a/arch/m68knommu/kernel/vmlinux.lds.S b/arch/m68knommu/k= ernel/vmlinux.lds.S > > index ef33213..47e15eb 100644 > > --- a/arch/m68knommu/kernel/vmlinux.lds.S > > +++ b/arch/m68knommu/kernel/vmlinux.lds.S >=20 > The crash happened on m68k with MMU, not m68knommu. >=20 Hmm, OK then. Could you please see if the crash happens if you return early in kernel/params.c::version_sysfs_builtin() ? Also, do you see anything in __modev section of your build? Thanks, Dmitry