Re: Early crash

David Miller
2011-02-08T03:31:52Z

From: Rusty Russell <rusty@rustcorp.com.au>
Date: Tue, 8 Feb 2011 13:42:48 +1030

> But OTOH, this is an old problem which was faced by module params since
> pre-git. And we use the-align-to-void*-size method there; I vaguely recall
> inserting it.
>
> You've now got me wondering whether these platforms have broken builtin
> module parameters, but I think it would crash iterating if you had any
> boot parameters at all if that were the case.
>
> So do we fix that now too, or wait for it to break?

Good question.

I think the magic align magic on x86_64 in gcc only kicks in if a
structure is larger than a certain size. But of course they could
change that at some point if they like.

So probably better safe than sorry.