public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: torvalds@linux-foundation.org
Cc: dtor@vmware.com, linux-kernel@vger.kernel.org,
	geert@linux-m68k.org, rusty@rustcorp.com.au,
	linux-m68k@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/3] module: deal with alignment issues in built-in module versions
Date: Thu, 17 Feb 2011 13:17:02 -0800 (PST)	[thread overview]
Message-ID: <20110217.131702.112601300.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTinA-OP69fqf5jLfedk=dL2vmwdUyzn5E6FHR=Zw@mail.gmail.com>

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Thu, 17 Feb 2011 13:11:56 -0800

> EVERY SINGLE OF YOUR ARGUMENTS WORK FOR "pointer" TOO!

It at least will not happen at the current time, because GCC only
plays these games on aggregates.

Also, for exception tables, we've avoided this problem because
we emit the exception tables by hand using inline asm and therefore
explicitly control all aspects of the alignment and size.

The GCC manual even documents the alignment attribute behavior.

Also, please don't shoot the messenger, I didn't make GCC behave this
way but I doubt you'll have any luck undoing this behavior in the
tools which therefore means as pragmatists we have to handle it one
way or another.

  reply	other threads:[~2011-02-17 21:17 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08  0:02 [PATCH 1/3] module: deal with alignment issues in built-in module versions Dmitry Torokhov
2011-02-08  0:02 ` [PATCH 2/3] module: deal with alignment issues in built-in module parameters Dmitry Torokhov
2011-02-08  0:02 ` [PATCH 3/3] module: do not hide __modver_version_show declaration behind ifdef Dmitry Torokhov
2011-02-08 21:12 ` [PATCH 1/3] module: deal with alignment issues in built-in module versions Geert Uytterhoeven
2011-02-17 12:43   ` Geert Uytterhoeven
2011-02-11 22:03 ` [PATCH v2] module: deal with alignment issues in built-in module parameters Dmitry Torokhov
2011-02-13 23:04   ` Rusty Russell
2011-02-17 17:24 ` [PATCH 1/3] module: deal with alignment issues in built-in module versions Linus Torvalds
2011-02-17 17:31   ` Dmitry Torokhov
2011-02-17 17:45     ` Linus Torvalds
2011-02-17 18:00       ` Dmitry Torokhov
2011-02-17 18:06         ` Linus Torvalds
2011-02-17 21:01           ` David Miller
2011-02-17 21:11             ` Linus Torvalds
2011-02-17 21:17               ` David Miller [this message]
2011-02-17 21:54                 ` Linus Torvalds
2011-02-17 22:01                   ` David Miller
2011-02-17 22:19                     ` Dmitry Torokhov
2011-02-17 22:23                       ` David Miller
2011-02-17 22:48                         ` Linus Torvalds
2011-02-17 23:08                           ` Linus Torvalds
2011-02-17 23:19                             ` David Miller
2011-02-19  0:14                             ` Benjamin Herrenschmidt
2011-02-21  4:00                               ` Rusty Russell
2011-02-21  7:38                                 ` Geert Uytterhoeven
2011-02-21  7:49                                   ` Dmitry Torokhov
2011-02-21 13:25                                     ` Geert Uytterhoeven
2011-02-22  1:58                                 ` Benjamin Herrenschmidt
2011-02-22  2:03                                   ` Linus Torvalds
2011-02-22  7:02                                     ` Dmitry Torokhov
2011-02-22 17:08                                       ` Jesper Nilsson
2011-02-22 20:47                                         ` Linus Torvalds
2011-02-23 15:00                                           ` Jesper Nilsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110217.131702.112601300.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dtor@vmware.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox