From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 1/3] module: deal with alignment issues in built-in module versions Date: Sun, 20 Feb 2011 23:49:47 -0800 Message-ID: <20110221074947.GA31152@dtor-ws.eng.vmware.com> References: <20110217.140119.39175251.davem@davemloft.net> <20110217221957.GA11244@dtor-ws.eng.vmware.com> <20110217.142320.102554706.davem@davemloft.net> <1298074455.2460.85.camel@pasglop> <87pqqmrq9q.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from smtp-outbound-2.vmware.com ([65.115.85.73]:59034 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751486Ab1BUHtr (ORCPT ); Mon, 21 Feb 2011 02:49:47 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-m68k-owner@vger.kernel.org List-Id: linux-m68k@vger.kernel.org To: Geert Uytterhoeven Cc: Rusty Russell , Benjamin Herrenschmidt , Linus Torvalds , David Miller , linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org, linux-arch@vger.kernel.org On Mon, Feb 21, 2011 at 08:38:46AM +0100, Geert Uytterhoeven wrote: > On Mon, Feb 21, 2011 at 05:00, Rusty Russell = wrote: > >> Except that .long is 32-bit on ppc64 :-( You need .llong for 64-bi= t. > > > > OK, all options suck. =A0Do we want the workaround or not? >=20 > We can discuss about that until someone gets bitten by that. >=20 > But please fix the "aligned(sizeof(void *))"-in-one-place-only issue. >=20 How about this one then? Thanks. --=20 Dmitry =46rom f0e0e10b58b22047e36e21a022abf5e86b5819c2 Mon Sep 17 00:00:00 200= 1 =46rom: Dmitry Torokhov Date: Fri, 4 Feb 2011 13:30:10 -0800 Subject: [PATCH] module: explicitly align module_version_attribute stru= cture We force particular alignment when we generate attribute structures when generation MODULE_VERSION() data and we need to make sure that this alignment is followed when we iterate over these structures, otherwise we may crash on platforms whose natural alignment is not sizeof(void *), such as m68k. Reported-by: Geert Uytterhoeven Signed-off-by: Dmitry Torokhov --- include/linux/module.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/linux/module.h b/include/linux/module.h index e7c6385..de5cd21 100644 --- a/include/linux/module.h +++ b/include/linux/module.h @@ -62,7 +62,7 @@ struct module_version_attribute { struct module_attribute mattr; const char *module_name; const char *version; -}; +} __attribute__ ((__aligned__(sizeof(void *)))); =20 struct module_kobject { --=20 1.7.3.2