From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philippe De Muyter Subject: Re: [uClinux-dev] [PATCH v2 1/6] m68k: merge mmu and non-mmu versions of muldi3 Date: Wed, 20 Apr 2011 13:23:12 +0200 Message-ID: <20110420112312.GA30992@frolo.macqel> References: <1303278880-16153-2-git-send-email-gerg@snapgear.com> <1303278880-16153-3-git-send-email-gerg@snapgear.com> <20110420080609.GA24244@merkur.ravnborg.org> <20110420091216.GB3296@frolo.macqel> <4DAEA7F5.6080603@snapgear.com> <20110420095529.GC3296@frolo.macqel> <4DAEB2E1.6050404@snapgear.com> <20110420103802.GA26891@frolo.macqel> <4DAEBD13.7070605@snapgear.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailrelay002.isp.belgacom.be ([195.238.6.175]:23791 "EHLO mailrelay002.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753620Ab1DTLXU (ORCPT ); Wed, 20 Apr 2011 07:23:20 -0400 Content-Disposition: inline In-Reply-To: <4DAEBD13.7070605@snapgear.com> Sender: linux-m68k-owner@vger.kernel.org List-Id: linux-m68k@vger.kernel.org To: Greg Ungerer Cc: uClinux development list , linux-m68k@vger.kernel.org, Greg Ungerer Hi Greg, On Wed, Apr 20, 2011 at 09:01:39PM +1000, Greg Ungerer wrote: > Hi Philippe, > > On 20/04/11 20:38, Philippe De Muyter wrote: >> Hi Greg, >> >> On Wed, Apr 20, 2011 at 08:18:09PM +1000, Greg Ungerer wrote: >>>> >>>> The 68340 has it also. (And I have an old linux port for this processor) >>> >>> That is just a SoC that contains a 68020 though, so __mc68020__ would >>> be defined for that. >> >> No, this is a cpu32 core, which is a subset of a 68020, so gcc does not >> define __mc68020__, or at least should not (there are old bug reports >> about that). > > Modern gcc still does, from a gcc-4.5.1: > > # m68k-linux-gcc -mcpu32 -dM -E - < /dev/null | grep mc68020 > #define __mc68020__ 1 > #define __mc68020 1 > #define mc68020 1 > > >>>> I surmise the 68360 has it also. >>> >>> I believe that is a SoC with a 68040 cpu core, so I would expect that >>> __mc68040__ would be correct for that. >> >> This is a cpu32+ core. >> >> Same here. >> >> Not that it is that important now :) > > Does cpu32 always support the 64bit mul? Yes AFAIK. > If so we can just add __mcpu32__ to the conditional check list. That would be safer. Thanks Philippe