From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org,
Akinobu Mita <akinobu.mita@gmail.com>,
linux-kernel@vger.kernel.org, Ben Hutchings <ben@decadent.org.uk>
Subject: Re: [PATCH/RFC] m68k/bitops: Make bitmap data pointer of atomic ops volatile
Date: Mon, 6 Jun 2011 22:11:15 +0200 [thread overview]
Message-ID: <201106062211.15247.arnd@arndb.de> (raw)
In-Reply-To: <1307390873-29687-1-git-send-email-geert@linux-m68k.org>
On Monday 06 June 2011 22:07:53 Geert Uytterhoeven wrote:
>
> This fixes a.o.
>
> drivers/ide/ide-io.c: In function ‘ide_lock_host’:
> drivers/ide/ide-io.c:415: warning: passing argument 2 of ‘__constant_test_and_set_bit’ discards qualifiers from pointer target type
> drivers/ide/ide-io.c:415: warning: passing argument 2 of ‘__generic_test_and_set_bit’ discards qualifiers from pointer target type
>
> Suggested-by: Ben Hutchings <ben@decadent.org.uk>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
I think the correct fix would be to mark the variable not volatile, as it
clearly has no business be marked as such. That doesn't mean your patch
is wrong, though. It probably doesn't hurt to do both.
Arnd
next prev parent reply other threads:[~2011-06-06 20:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 20:07 [PATCH/RFC] m68k/bitops: Make bitmap data pointer of atomic ops volatile Geert Uytterhoeven
2011-06-06 20:11 ` Arnd Bergmann [this message]
2011-06-07 7:09 ` Geert Uytterhoeven
[not found] ` <BANLkTin8XNA+ocdjUhtzVOQNxOGFsYa1mA@mail.gmail.com>
2011-06-07 11:22 ` Arnd Bergmann
[not found] ` <201106071322.29884.arnd@arndb.de>
2011-06-07 13:35 ` Ben Hutchings
[not found] ` <20110607133500.GX29924@decadent.org.uk>
2011-06-07 13:56 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106062211.15247.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akinobu.mita@gmail.com \
--cc=ben@decadent.org.uk \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox