From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Nieder Subject: Re: [m68k] in modpost: "strlen" [iscsi_target_mod.ko] undefined! (and others) Date: Sun, 1 Jan 2012 17:39:31 -0600 Message-ID: <20120101233931.GA25837@elie.hsd1.il.comcast.net> References: <20111116181424.14920.7730.reportbug@ara5.mirbsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Thorsten Glaser Cc: Nicholas Bellinger , Greg Ungerer , linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org, target-devel@vger.kernel.org List-Id: linux-m68k@vger.kernel.org Thorsten Glaser wrote[1]: > Dixi quod=E2=80=A6 >> So, please, compile the Linux kernel with -ffreestanding, too. > > Just to keep this bugreport in the loop: that fixes the FTBFS error. Yep, sounds like a reasonable idea, though these calls to "strncat(buf, str, strlen(str))" in the iscsi driver are still a little insane. Could you suggest a patch to arch/m68k/Makefile to do that? Thanks, Jonathan [1] http://bugs.debian.org/648996 Background: commit 6edfba1b33c7 Author: Andi Kleen Date: Sat Mar 25 16:29:49 2006 +0100 [PATCH] x86_64: Don't define string functions to builtin gcc should handle this anyways, and it causes problems when sprintf is turned into strcpy by gcc behind our backs and the C fallback version of strcpy is actually defining __builtin_str= cpy Then drop -ffreestanding from the main Makefile because it isn't needed anymore and implies -fno-builtin, which is wrong now. (it was only added for x86-64, so dropping it should be safe)