From: Philippe De Muyter <phdm@macqel.be>
To: gerg@snapgear.com
Cc: linux-m68k@vger.kernel.org, Greg Ungerer <gerg@uclinux.org>
Subject: Re: [PATCH v2] m68k: fix ColdFire clear cache operation
Date: Wed, 11 Jul 2012 17:51:48 +0200 [thread overview]
Message-ID: <20120711155148.GA26577@frolo.macqel> (raw)
In-Reply-To: <1341967036-14645-1-git-send-email-gerg@snapgear.com>
On Wed, Jul 11, 2012 at 10:37:16AM +1000, gerg@snapgear.com wrote:
> + __asm__ __volatile__ (
> + "movec %0,%%cacr\n\t"
> + "nop\n\t"
This could be written as
"movec %0,%%cacr; nop"
i.e. :
final "\n\t" is useless
other "\n\t" may be replaced by ";"
Philippe
next prev parent reply other threads:[~2012-07-11 15:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 0:37 [PATCH v2] m68k: fix ColdFire clear cache operation gerg
2012-07-11 15:51 ` Philippe De Muyter [this message]
2012-07-12 1:50 ` Greg Ungerer
2012-07-16 19:13 ` Geert Uytterhoeven
2012-07-17 6:03 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120711155148.GA26577@frolo.macqel \
--to=phdm@macqel.be \
--cc=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox