Re: [PATCH RESEND 4/4] m68k/atari: fix SCC initialization for debug console

Michael Schmitz
2014-05-26T01:23:35Z

Hi Finn,

On Sun, May 25, 2014 at 10:37 PM, Finn Thain <fthain@telegraphics.com.au> wrote:
>
> On Sun, 25 May 2014, Geert Uytterhoeven wrote:
>
>> Has anyone tested this on Atari?
>
> The patch doesn't change behaviour. If someone wanted to test it, they'd
> also need to make changes like this:
>
> diff --git a/arch/m68k/kernel/head.S b/arch/m68k/kernel/head.S
> index 3ab329b..b210a29 100644
> --- a/arch/m68k/kernel/head.S
> +++ b/arch/m68k/kernel/head.S
> @@ -2752,7 +2752,7 @@ L(scc_initable_mac):
> #ifdef CONFIG_ATARI
> /* #define USE_PRINTER */
> /* #define USE_SCC_B */
> -/* #define USE_SCC_A */
> +#define USE_SCC_A
> #define USE_MFP
>
> #if defined(USE_SCC_A) || defined(USE_SCC_B)
>
> That difficulty is one reason why this patch series replaces some other
> buried macros with Kconfig symbols...
>

Does it even work if both USE_SCC_A and USE_MFP are defined? I've only
ever had defined one or the other.

Would not object to making that change too, if it happens to work OK.
More to test, sigh.

Cheers,

Michael

> --