[PATCH v3 01/37] ncr5380: Use printk() not pr_debug()

Finn Thain
2014-11-12T05:11:47Z

[-- Attachment #1: ncr5380-use-printk-not-pr_debug --]
[-- Type: text/plain, Size: 1035 bytes --]

Having defined NDEBUG, and having set the console log level, I'd like to see
some output. Don't use pr_debug(), it's annoying to have to define DEBUG as
well.

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>

---

Use of pr_debug() here was a bad idea of mine. Joe was right when
he questioned it.

---
drivers/scsi/NCR5380.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux/drivers/scsi/NCR5380.h
===================================================================
--- linux.orig/drivers/scsi/NCR5380.h 2014-11-12 16:10:43.000000000 +1100
+++ linux/drivers/scsi/NCR5380.h 2014-11-12 16:10:46.000000000 +1100
@@ -296,7 +296,8 @@ struct NCR5380_hostdata {
#endif

#define dprintk(flg, fmt, ...) \
- do { if ((NDEBUG) & (flg)) pr_debug(fmt, ## __VA_ARGS__); } while (0)
+ do { if ((NDEBUG) & (flg)) \
+ printk(KERN_DEBUG fmt, ## __VA_ARGS__); } while (0)

#if NDEBUG
#define NCR5380_dprint(flg, arg) \