Re: [RFC v5 00/26] Re-use nvram module

Finn Thain
2015-08-17T08:04:59Z

On Sun, 16 Aug 2015, Geert Uytterhoeven wrote:

> Hi Finn,
>
> On Sat, Jul 25, 2015 at 9:45 AM, Finn Thain <fthain@telegraphics.com.au>
> wrote:
> > The generic NVRAM module, drivers/char/generic_nvram, implements a
> > /dev/nvram misc device. It is used only by 32-bit PowerPC platforms
> > and isn't generic enough to be more widely used.
>
> [...]
>
> Thanks!
>
> You can add my
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> to patches 03, 04, 11, 19, 23, 24, 25, 26.

Thanks for reviewing.

>
> BTW, checkpatch reported a few newly-introduced whitespace errors in
> patches 03, 05, 16, 24, and 25.

I will check again, but I'm sure those are all deliberate. I examined all
the "errors" and "warnings" before submitting.

checkpatch doesn't really understand the difference between whitespace
used for indentation of statements (according to scope) and whitespace
used for alignment of terms or parameters (when line-wrapped). Any tool
that fails to make that distinction can't be depended upon to correctly
validate the elisp in Documentation/CodingStyle, for example.

--

>
> Gr{oetje,eeting}s,
>
> Geert
>