From: Tom Bogendoerfer <tsbogend@alpha.franken.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Alexander Kuleshov <kuleshovmail@gmail.com>,
Sam Creasey <sammy@sammy.net>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] m68k/sun3: Fix virtual addresses of clock and interrupt register
Date: Fri, 25 Sep 2015 12:45:53 +0200 [thread overview]
Message-ID: <20150925104553.GA22917@alpha.franken.de> (raw)
In-Reply-To: <CAMuHMdU-ZjWPw8D2KYjBgMdRM_k+BTfhKC81RcSkB_s8Mzjmwg@mail.gmail.com>
On Fri, Sep 25, 2015 at 09:21:34AM +0200, Geert Uytterhoeven wrote:
> On Mon, Sep 14, 2015 at 11:40 AM, Alexander Kuleshov
> <kuleshovmail@gmail.com> wrote:
> > The MMU base is 32 bits size - 0xfe000000, seems that we missed
> > one zero in the definition of the clock and interrupt register
> > addresses.
>
> Thanks for your patch!
>
> Have you tested this?
>
> This means enabling/disabling interrupts never worked on Sun 3, which
> I find a bit difficult to believe.
> There are other 0x0f?????? addresses in arch/m68k/sun3/mmu_emu.c.
which are the correct one. Sun3 MMU doesn't even handle full 32bit
addresses, it's only capable of 28 bits. That's the reason why normal
m68k linux user space binaries can't work.
So this patch is broken. And I'm sure the unpatched version works.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2015-09-25 10:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1442223611-30175-1-git-send-email-kuleshovmail@gmail.com>
2015-09-25 7:21 ` [PATCH] m68k/sun3: Fix virtual addresses of clock and interrupt register Geert Uytterhoeven
2015-09-25 7:50 ` Alexander Kuleshov
2015-09-25 10:45 ` Tom Bogendoerfer [this message]
2015-09-14 9:40 Alexander Kuleshov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150925104553.GA22917@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=geert@linux-m68k.org \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=sammy@sammy.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox