Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers

Ondrej Zary
2015-11-20T11:40:03Z

On Friday 20 November 2015, Finn Thain wrote:
>
> On Fri, 20 Nov 2015, Christoph Hellwig wrote:
>
> > On Fri, Nov 20, 2015 at 07:19:21PM +1100, Finn Thain wrote:
> >
> > > Yes. I didn't do that conversion because I don't have ISA hardware and
> > > I don't understand ISA probing.
> > >
> > > The present patch set doesn't seek to resurrect the ISA drivers. But I
> > > am trying to avoid regressions.
> > >
> > > I have mixed feelings about the ISA drivers. ISA DMA support
> > > complicates things (it was never completed) and DMA seems to be the
> > > main obstacle to merging the two core driver forks.
> >
> > I'd love to be able to get rid of the ISA drivers to be honest.
>
> Is that because of their use of scsi_module.c or their general decrepitude
> or something else?

scsi_module.c usage shouldn't be hard to fix. I can do that after finding a working setup.

> > Given that they appear to be gravely broken before your cleanups this
> > might be an opportunity to get rid of them.
>
> At this stage, that's unclear (to me). It could be that g_NCR5380.c is not
> broken. It could be that the core driver can't handle certain targets. I
> think we need to do more testing.

Maybe I was just unlucky and tested a drive that never worked with this driver.

Working ISA means more testing possibilities. It's much easier to get an ISA card than a Sun or Atari. Also faster CPU (such as 1 GHz P3) means quicker testing.

--
Ondrej Zary