Re: [PATCH v3 43/77] ncr5380: Standardize reselection handling

Hannes Reinecke
2015-12-22T07:41:05Z

On 12/22/2015 02:18 AM, Finn Thain wrote:
> Bring the two NCR5380_reselect() implementations into agreement.
>
> Replace infinite loops in atari_NCR5380.c with timeouts, as per NCR5380.c.
>
> Remove 'abort' flag in NCR5380.c as per atari_NCR5380.c -- if reselection
> fails, there may be no MESSAGE IN phase so don't attempt data transfer.
>
> During selection, don't interfere with the chip registers after a
> reselection interrupt intervenes.
>
> Clean up some trivial issues with code style, comments and printk.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
>
> ---
> drivers/scsi/NCR5380.c | 115 +++++++++++++++++++++++--------------------
> drivers/scsi/atari_NCR5380.c | 50 ++++++++++--------
> 2 files changed, 93 insertions(+), 72 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)