Re: [PATCH v3 68/77] ncr5380: Fix whitespace issues using regexp

Joe Perches
2015-12-22T14:46:55Z

On Tue, 2015-12-22 at 12:18 +1100, Finn Thain wrote:
> This patch is just the result of two substitutions. The first removes any
> tabs and spaces at the end of the line. The second replaces runs of
> tabs and spaces at the beginning of comment lines with a single space.

I think the second of these isn't done well.
Many of these comments post reformatting are
much worse to read because of lost alignment.

For instance:

> +/*
>   * Function : int NCR5380_select(struct Scsi_Host *instance,
> - *                               struct scsi_cmnd *cmd)
> + * struct scsi_cmnd *cmd)
>   *
>   * Purpose : establishes I_T_L or I_T_L_Q nexus for new or existing command,
> - *      including ARBITRATION, SELECTION, and initial message out for
> - *      IDENTIFY and queue messages.
> + * including ARBITRATION, SELECTION, and initial message out for
> + * IDENTIFY and queue messages.